Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add created multisig addresses to local wallet store #1136

Open
2 tasks
whyrusleeping opened this issue Jan 22, 2020 · 4 comments
Open
2 tasks

Add created multisig addresses to local wallet store #1136

whyrusleeping opened this issue Jan 22, 2020 · 4 comments
Labels
area/wallet Area: Wallet effort/days Effort: Multiple Days kind/enhancement Kind: Enhancement need/team-input Hint: Needs Team Input tribute

Comments

@whyrusleeping
Copy link
Member

whyrusleeping commented Jan 22, 2020

Edited by @jennijuju

Having a better multisig experience is important for the Filecoin network/ecosystem.

This is a great project for tributes to take on:

  • Design the architecture for having multig addresses to local wallet store #6748
    Originally from @whyrusleeping:
    We should try to treat multisigs we create as 'accounts' as much as we can. There are a number of places where we can make the UX nice here:
    • Include multisig addresses in the wallet
    • This means lotus wallet list shows multisig addresses
    • It also makes it easier to remember your addresses
    • Allow lotus send to send from multisigs
    • Allow a multisig wallet to be your 'default' address
    • We technically get this for free if we include them in the wallet, but this has implications
  • Implementation ~1 week

should fix #5647

@arajasek arajasek self-assigned this Jul 23, 2020
@daviddias daviddias added the area/ux Area: UX label Jul 30, 2020
@arajasek arajasek added the P2 P2: Should be resolved label Aug 4, 2020
@jennijuju jennijuju self-assigned this Nov 6, 2020
@jennijuju jennijuju added area/wallet Area: Wallet and removed area/ux Area: UX labels Jan 19, 2021
@jennijuju jennijuju added the effort/days Effort: Multiple Days label Feb 24, 2021
@jennijuju
Copy link
Member

@Kubuxu will work on a design and have some AI for later this week.

@whyrusleeping
Copy link
Member Author

This would be really great to do, improving how people use and interact with multisigs in lotus will have significant gains all across the board in terms of security and convenience of using the protocol.

Filecoin does make custodying funds safely pretty easy, but if we make the UX here better and seamless, i really think a lot of people will benefit.

@jennijuju jennijuju added P1 P1: Must be resolved and removed P2 P2: Should be resolved labels Jul 14, 2021
@jennijuju jennijuju added this to the v1.11.2 milestone Aug 14, 2021
@jennijuju jennijuju removed the P1 P1: Must be resolved label Aug 14, 2021
@jennijuju jennijuju removed this from the v1.11.2 milestone Aug 17, 2021
@TippyFlitsUK TippyFlitsUK added need/team-input Hint: Needs Team Input kind/enhancement Kind: Enhancement labels Mar 30, 2022
@stuberman
Copy link

Any updates to this? @Reiers @ribasushi This is becoming more critical to SPs.

@llifezou
Copy link
Contributor

Any updates to this? @Reiers @ribasushi This is becoming more critical to SPs.

Hi @stuberman

Allow me to recommend a wallet: OpenFilWallet (https://github.com/OpenFilWallet/OpenFilWallet). It was designed to focus on building an easy-to-use HD wallet for SP, which is currently available. It is completely open source and focuses on security. Whether it is a question or a suggestion, feedback is welcome.

I noticed that you are an architect in the security field, if you can give some advice on security, that would be very much appreciated

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wallet Area: Wallet effort/days Effort: Multiple Days kind/enhancement Kind: Enhancement need/team-input Hint: Needs Team Input tribute
Projects
None yet
Development

No branches or pull requests

8 participants