Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force users to set the lotus-miner legacy markets config to false #10862

Closed
Tracked by #10533
shrenujbansal opened this issue May 12, 2023 · 3 comments
Closed
Tracked by #10533

Force users to set the lotus-miner legacy markets config to false #10862

shrenujbansal opened this issue May 12, 2023 · 3 comments
Milestone
LM-Tech-Debt-Lega...

Comments

@shrenujbansal
Copy link
Contributor

shrenujbansal commented May 12, 2023 •
edited
Loading

Lotus-markets are being disabled in favor of boost
The default config has already been changed to disable lotus-markets. However, SPs can accidentally/intentionally keep their old config and keep running with lotus-markets code
This code is going away soon, so provide a loud notification to users to disable this
@rjan90
Copy link
Contributor

rjan90 commented May 12, 2023

Similar to what happened with the SplitStore config, we should force users to explicitly set this in the next feature release after a network upgrade (PR for reference: #10488 ).

@rjan90
Copy link
Contributor

rjan90 commented May 15, 2023

Added an alert as a start here: #10868

@rjan90 rjan90 mentioned this issue Jun 14, 2023
Closed
@rjan90 rjan90 changed the title Show users a loud warning if they still have lotus markets enabled in their miner config Force users to set the lotus-miner legacy markets miner config to false Jun 14, 2023
@rjan90 rjan90 changed the title Force users to set the lotus-miner legacy markets miner config to false Force users to set the lotus-miner legacy markets config to false Jun 14, 2023
@rjan90 rjan90 added this to the LM-Tech-Debt-Legacy-Markets milestone Jun 20, 2023
@rjan90
Copy link
Contributor

rjan90 commented Jun 3, 2024

Closing this ticket, since the legacy markets with be completely removed in: #12005

@rjan90 rjan90 closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
LM-Tech-Debt-Legacy-Markets
Development

No branches or pull requests
2 participants
@rjan90 @shrenujbansal