Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet import: support MetaMask keys #10677

Open
raulk opened this issue Apr 17, 2023 · 1 comment
Open

wallet import: support MetaMask keys #10677

raulk opened this issue Apr 17, 2023 · 1 comment
Labels
area/wallet Area: Wallet help wanted Extra attention is needed kind/feature Kind: Feature P3 P3: Might get resolved

Comments

@raulk
Copy link
Member

raulk commented Apr 17, 2023

There are two missing functionalities in wallet import:

  1. It cannot import delegated keys exported by wallet export, thus breaking round tripping.
  2. It does not support private keys exported from MetaMask.

Concretely, (2) is necessary to do low-level recovery from funky situations using Lotus directly (like sending low-level RBF messages).

@jennijuju jennijuju added help wanted Extra attention is needed kind/feature Kind: Feature P3 P3: Might get resolved area/wallet Area: Wallet labels Apr 17, 2023
@rjan90
Copy link
Contributor

rjan90 commented Aug 21, 2023

It cannot import delegated keys exported by wallet export, thus breaking round tripping.

This is supported today. Deleted t4-here:

lotus wallet delete t410fo7ng443xgufn4hjvkdgs6agiivutl35wq5ufzcy
Soft deleting address: t410fo7ng443xgufn4hjvkdgs6agiivutl35wq5ufzcy
Hard deletion of the address in `~/.lotus/keystore` is needed for permanent removal

Import by typing in private-key:

lotus wallet import                                             
Enter private key(not display in the terminal): 
imported key t410fo7ng443xgufn4hjvkdgs6agiivutl35wq5ufzcy successfully!

Import delegated key by path:

lotus wallet import /Users/phi/lotus/t4.key
imported key t410fo7ng443xgufn4hjvkdgs6agiivutl35wq5ufzcy successfully!

Afaict, importing MetaMask keys are not supported today. I have updated the headline to reflect the current state of lotus wallet import

@rjan90 rjan90 changed the title wallet import: support exported Delegated keys + MetaMask keys wallet import: support MetaMask keys Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wallet Area: Wallet help wanted Extra attention is needed kind/feature Kind: Feature P3 P3: Might get resolved
Projects
None yet
Development

No branches or pull requests

4 participants
@raulk @rjan90 @jennijuju and others