-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce LimitedVec type abstraction #335
Comments
Specific concerns:
|
@Stebalien this was in nv16 milestone. Is it still relevant? If so, when? |
We audited this and didn't find any issues. However, it would still be nice to introduce some kind of On the other hand, this is hardly a priority as we have quite a few size checks (e.g., when setting miner info, etc.). This would just make it easier to reason about those sizes (and allow us to remove the explicit checks). |
From #499, also constants like max_aggregated_sectors pre_commit_sector_batch_max_size declarations_max |
So, once we get proper memory limits:
|
Unlike the go actors, we don't enforce maximum sizes in CBOR. Specifically:
We need to make sure that the actors have logical checks to ensure that we can't accidentally create state objects that cause problems for, e.g., cron.
Ideally, we'd do this with some length-limited helper types. E.g.:
The text was updated successfully, but these errors were encountered: