[EPIC]Test Coverage

[vyzo]

Our task is to improve coverage across the board, by porting the spec-actors test suite and ensuring 1-to-1 correspondence (to the point it makes sense).
This issue is here to track progress towards that goal

Actor Coverage

• account -- Account Actor Test Coverage #23
• cron -- Cron Actor Test Coverage #24
• init -- Init Actor Test Coverage #25
• market -- Market Actor Test Coverage #26 🔥
• miner -- Miner Actor Test Coverage #27 🔥
• multisig -- Multisig actor test coverage #28 🔥
• paych -- Paych Actor Test Coverage #29
• power -- Power Actor Test Coverage #30 🔥
• reward -- Reward Actor Test Coverage #31
• system -- System Actor Test Coverage #32
• verifreg -- Verifreg Actor Test Coverage #33 🔥

Initial Test Coverage Details

This is the current coverage as reported by tarpaulin:

Mar 02 18:29:54.671  INFO cargo_tarpaulin::report: Coverage Results:
|| Tested/Total Lines:
|| actors/account/src/lib.rs: 17/22
|| actors/account/tests/account_actor_test.rs: 30/32
|| actors/cron/src/lib.rs: 23/28
|| actors/cron/tests/cron_actor_test.rs: 71/71
|| actors/init/src/lib.rs: 41/55
|| actors/init/src/state.rs: 17/19
|| actors/init/tests/init_actor_test.rs: 130/132
|| actors/market/src/deal.rs: 0/15
|| actors/market/src/lib.rs: 9/816
|| actors/market/src/policy.rs: 0/18
|| actors/market/src/state.rs: 21/311
|| actors/market/tests/market_actor_test.rs: 23/69
|| actors/miner/src/bitfield_queue.rs: 0/55
|| actors/miner/src/deadline_assignment.rs: 0/51
|| actors/miner/src/deadline_info.rs: 0/40
|| actors/miner/src/deadline_state.rs: 0/594
|| actors/miner/src/deadlines.rs: 0/34
|| actors/miner/src/expiration_queue.rs: 0/438
|| actors/miner/src/lib.rs: 0/2353
|| actors/miner/src/monies.rs: 0/65
|| actors/miner/src/partition_state.rs: 0/382
|| actors/miner/src/policy.rs: 0/52
|| actors/miner/src/sector_map.rs: 0/64
|| actors/miner/src/sectors.rs: 0/67
|| actors/miner/src/state.rs: 0/475
|| actors/miner/src/termination.rs: 0/15
|| actors/miner/src/vesting_state.rs: 0/55
|| actors/multisig/src/lib.rs: 0/345
|| actors/multisig/src/state.rs: 0/41
|| actors/multisig/src/types.rs: 0/2
|| actors/paych/src/lib.rs: 113/171
|| actors/paych/src/state.rs: 2/2
|| actors/paych/src/types.rs: 14/14
|| actors/paych/tests/paych_actor_test.rs: 478/500
|| actors/power/src/lib.rs: 0/368
|| actors/power/src/state.rs: 16/166
|| actors/reward/src/expneg.rs: 6/6
|| actors/reward/src/lib.rs: 67/115
|| actors/reward/src/logic.rs: 30/30
|| actors/reward/src/state.rs: 39/50
|| actors/reward/tests/reward_actor_test.rs: 131/137
|| actors/runtime/src/actor_error.rs: 6/16
|| actors/runtime/src/builtin/network.rs: 0/3
|| actors/runtime/src/builtin/sector.rs: 0/4
|| actors/runtime/src/builtin/shared.rs: 3/16
|| actors/runtime/src/builtin/singletons.rs: 4/10
|| actors/runtime/src/lib.rs: 13/13
|| actors/runtime/src/runtime/actor_blockstore.rs: 0/3
|| actors/runtime/src/runtime/fvm.rs: 0/160
|| actors/runtime/src/runtime/mod.rs: 2/12
|| actors/runtime/src/test_utils.rs: 232/369
|| actors/runtime/src/util/balance_table.rs: 33/41
|| actors/runtime/src/util/chaos/mod.rs: 0/84
|| actors/runtime/src/util/downcast.rs: 16/56
|| actors/runtime/src/util/multimap.rs: 27/34
|| actors/runtime/src/util/set.rs: 23/27
|| actors/runtime/src/util/set_multimap.rs: 31/42
|| actors/runtime/src/util/unmarshallable.rs: 9/13
|| actors/runtime/tests/alpha_beta_filter_test.rs: 82/82
|| actors/runtime/tests/balance_table_test.rs: 31/31
|| actors/runtime/tests/multimap_test.rs: 39/39
|| actors/runtime/tests/set_multimap_test.rs: 27/27
|| actors/runtime/tests/set_test.rs: 26/26
|| actors/system/src/lib.rs: 0/8
|| actors/verifreg/src/lib.rs: 0/294
|| actors/verifreg/src/state.rs: 0/7
|| actors/verifreg/src/types.rs: 0/1
|| bundle/bundler/src/bin/bundler.rs: 0/13
|| bundle/bundler/src/lib.rs: 71/75
|| 
19.97% coverage, 1953/9781 lines covered

As we can see, we have quite low coverage with some actors not covered at all.

[raulk]

@vyzo mind posting the commit hash from which this coverage was calculated? 🙏

[vyzo]

It is current master:

commit 8f5cfca625ffed56d6b08ee727105405424b3588
Merge: 164b30b a011226
Author: raulk <...>
Date:   Wed Mar 2 15:28:03 2022 +0000

    Merge pull request #20 from filecoin-project/raulk/apply-renames

[raulk]

Mr. @ZenGround0 -- can we consider this closed now? 🎉 🎉🎉🎉🎉