From 783231af9bd6934167a6e9d5dc054248cfc094b3 Mon Sep 17 00:00:00 2001 From: Aayush Date: Thu, 12 Jan 2023 10:54:25 -0500 Subject: [PATCH] Runtime: Don't convert syscall errors --- Cargo.lock | 50 +++++++++++----------- actors/account/Cargo.toml | 2 +- actors/cron/Cargo.toml | 2 +- actors/datacap/Cargo.toml | 2 +- actors/datacap/src/lib.rs | 4 +- actors/eam/Cargo.toml | 2 +- actors/ethaccount/Cargo.toml | 2 +- actors/evm/Cargo.toml | 2 +- actors/evm/src/interpreter/system.rs | 14 +++++- actors/init/Cargo.toml | 2 +- actors/market/Cargo.toml | 2 +- actors/miner/Cargo.toml | 2 +- actors/multisig/Cargo.toml | 2 +- actors/paych/Cargo.toml | 2 +- actors/placeholder/Cargo.toml | 4 +- actors/power/Cargo.toml | 2 +- actors/reward/Cargo.toml | 2 +- actors/system/Cargo.toml | 2 +- actors/verifreg/Cargo.toml | 2 +- runtime/Cargo.toml | 6 +-- runtime/src/runtime/fvm.rs | 64 ++-------------------------- runtime/src/runtime/mod.rs | 63 ++++++++++++++++++++++++++- runtime/src/test_utils.rs | 22 +++------- state/Cargo.toml | 2 +- test_vm/Cargo.toml | 2 +- test_vm/src/lib.rs | 16 +++---- 26 files changed, 140 insertions(+), 137 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 4f0d03aa36..30a1b31604 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2256,7 +2256,7 @@ dependencies = [ [[package]] name = "frc42_dispatch" version = "3.0.0" -source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#9fb649e70b9ba333b1944a4696f2f6bae9f9793e" +source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#d8a2364f9ea23428ac095c0360211a4696f1a21b" dependencies = [ "frc42_hasher", "frc42_macros", @@ -2269,7 +2269,7 @@ dependencies = [ [[package]] name = "frc42_hasher" version = "1.3.0" -source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#9fb649e70b9ba333b1944a4696f2f6bae9f9793e" +source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#d8a2364f9ea23428ac095c0360211a4696f1a21b" dependencies = [ "fvm_sdk", "fvm_shared", @@ -2279,7 +2279,7 @@ dependencies = [ [[package]] name = "frc42_macros" version = "1.0.0" -source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#9fb649e70b9ba333b1944a4696f2f6bae9f9793e" +source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#d8a2364f9ea23428ac095c0360211a4696f1a21b" dependencies = [ "blake2b_simd", "frc42_hasher", @@ -2291,7 +2291,7 @@ dependencies = [ [[package]] name = "frc46_token" version = "3.1.0" -source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#9fb649e70b9ba333b1944a4696f2f6bae9f9793e" +source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#d8a2364f9ea23428ac095c0360211a4696f1a21b" dependencies = [ "anyhow", "cid 0.8.6", @@ -2440,7 +2440,7 @@ dependencies = [ [[package]] name = "fvm_actor_utils" version = "3.0.0" -source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#9fb649e70b9ba333b1944a4696f2f6bae9f9793e" +source = "git+https://github.com/filecoin-project/filecoin-actor-utils?branch=feat/fvm-m2#d8a2364f9ea23428ac095c0360211a4696f1a21b" dependencies = [ "anyhow", "cid 0.8.6", @@ -2568,9 +2568,9 @@ dependencies = [ [[package]] name = "fvm_sdk" -version = "3.0.0-alpha.21" +version = "3.0.0-alpha.22" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "aec61bd25838e3b26805506de57e11a51798498e6dec7b3075ec8ab4db6579f5" +checksum = "d51908aab9e7564fbcb278d78e31c12402b68c70517661780feb29adbb234aaf" dependencies = [ "cid 0.8.6", "fvm_ipld_encoding", @@ -2583,9 +2583,9 @@ dependencies = [ [[package]] name = "fvm_shared" -version = "3.0.0-alpha.15" +version = "3.0.0-alpha.16" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "6dea3259a0e147bcd22c5670441c1cbc2452e70763bf6688fb14e96f36cee2c2" +checksum = "a95666bb2e4b450f1750015a5f6c5da7544e744e295690cb4fcc5ba453283142" dependencies = [ "anyhow", "bitflags", @@ -3968,9 +3968,9 @@ dependencies = [ [[package]] name = "rustls" -version = "0.20.7" +version = "0.20.8" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "539a2bfe908f471bfa933876bd1eb6a19cf2176d375f82ef7f99530a40e48c2c" +checksum = "fff78fc74d175294f4e83b28343315ffcfb114b156f0185e9741cb5570f50e2f" dependencies = [ "log", "ring", @@ -4993,45 +4993,45 @@ dependencies = [ [[package]] name = "windows_aarch64_gnullvm" -version = "0.42.0" +version = "0.42.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "41d2aa71f6f0cbe00ae5167d90ef3cfe66527d6f613ca78ac8024c3ccab9a19e" +checksum = "8c9864e83243fdec7fc9c5444389dcbbfd258f745e7853198f365e3c4968a608" [[package]] name = "windows_aarch64_msvc" -version = "0.42.0" +version = "0.42.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "dd0f252f5a35cac83d6311b2e795981f5ee6e67eb1f9a7f64eb4500fbc4dcdb4" +checksum = "4c8b1b673ffc16c47a9ff48570a9d85e25d265735c503681332589af6253c6c7" [[package]] name = "windows_i686_gnu" -version = "0.42.0" +version = "0.42.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "fbeae19f6716841636c28d695375df17562ca208b2b7d0dc47635a50ae6c5de7" +checksum = "de3887528ad530ba7bdbb1faa8275ec7a1155a45ffa57c37993960277145d640" [[package]] name = "windows_i686_msvc" -version = "0.42.0" +version = "0.42.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "84c12f65daa39dd2babe6e442988fc329d6243fdce47d7d2d155b8d874862246" +checksum = "bf4d1122317eddd6ff351aa852118a2418ad4214e6613a50e0191f7004372605" [[package]] name = "windows_x86_64_gnu" -version = "0.42.0" +version = "0.42.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bf7b1b21b5362cbc318f686150e5bcea75ecedc74dd157d874d754a2ca44b0ed" +checksum = "c1040f221285e17ebccbc2591ffdc2d44ee1f9186324dd3e84e99ac68d699c45" [[package]] name = "windows_x86_64_gnullvm" -version = "0.42.0" +version = "0.42.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "09d525d2ba30eeb3297665bd434a54297e4170c7f1a44cad4ef58095b4cd2028" +checksum = "628bfdf232daa22b0d64fdb62b09fcc36bb01f05a3939e20ab73aaf9470d0463" [[package]] name = "windows_x86_64_msvc" -version = "0.42.0" +version = "0.42.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f40009d85759725a34da6d89a94e63d7bdc50a862acf0dbc7c8e488f1edcb6f5" +checksum = "447660ad36a13288b1db4d4248e857b510e8c3a225c822ba4fb748c0aafecffd" [[package]] name = "winreg" diff --git a/actors/account/Cargo.toml b/actors/account/Cargo.toml index ee1d4a46de..25856bab9a 100644 --- a/actors/account/Cargo.toml +++ b/actors/account/Cargo.toml @@ -14,7 +14,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } frc42_dispatch = "3.0.0" fvm_actor_utils = "3.0.0" serde = { version = "1.0.136", features = ["derive"] } diff --git a/actors/cron/Cargo.toml b/actors/cron/Cargo.toml index fbd5483ec5..97ae265040 100644 --- a/actors/cron/Cargo.toml +++ b/actors/cron/Cargo.toml @@ -15,7 +15,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } num-traits = "0.2.14" num-derive = "0.3.3" log = "0.4.14" diff --git a/actors/datacap/Cargo.toml b/actors/datacap/Cargo.toml index b96036902c..03300a51f1 100644 --- a/actors/datacap/Cargo.toml +++ b/actors/datacap/Cargo.toml @@ -23,7 +23,7 @@ fvm_actor_utils = "3.0.0" fvm_ipld_blockstore = "0.1.1" fvm_ipld_encoding = "0.3.2" fvm_ipld_hamt = "0.6.1" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } lazy_static = "1.4.0" num-derive = "0.3.3" num-traits = "0.2.14" diff --git a/actors/datacap/src/lib.rs b/actors/datacap/src/lib.rs index eb0cff4c6a..1332c469fb 100644 --- a/actors/datacap/src/lib.rs +++ b/actors/datacap/src/lib.rs @@ -4,14 +4,14 @@ use frc46_token::token::types::{ TransferFromParams, TransferFromReturn, TransferParams, TransferReturn, }; use frc46_token::token::{Token, TokenError, TOKEN_PRECISION}; -use fvm_actor_utils::messaging::{Messaging, MessagingError, Response}; +use fvm_actor_utils::messaging::{Messaging, MessagingError}; use fvm_actor_utils::receiver::ReceiverHookError; use fvm_ipld_encoding::RawBytes; use fvm_shared::address::Address; use fvm_shared::bigint::BigInt; use fvm_shared::econ::TokenAmount; use fvm_shared::error::{ErrorNumber, ExitCode}; -use fvm_shared::{ActorID, MethodNum, METHOD_CONSTRUCTOR, METHOD_SEND}; +use fvm_shared::{ActorID, MethodNum, Response, METHOD_CONSTRUCTOR, METHOD_SEND}; use lazy_static::lazy_static; use log::info; use num_derive::FromPrimitive; diff --git a/actors/eam/Cargo.toml b/actors/eam/Cargo.toml index 2d9012a435..0b8ddddbf3 100644 --- a/actors/eam/Cargo.toml +++ b/actors/eam/Cargo.toml @@ -24,7 +24,7 @@ fvm_ipld_blockstore = "0.1.1" fvm_ipld_encoding = "0.3.2" multihash = { version = "0.16.1", default-features = false } cid = "0.8.6" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } num-traits = "0.2.15" num-derive = "0.3.3" hex-literal = "0.3.4" diff --git a/actors/ethaccount/Cargo.toml b/actors/ethaccount/Cargo.toml index 941d8a1019..04852332e2 100644 --- a/actors/ethaccount/Cargo.toml +++ b/actors/ethaccount/Cargo.toml @@ -17,7 +17,7 @@ crate-type = ["cdylib", "lib"] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } serde = { version = "1.0.136", features = ["derive"] } fvm_ipld_encoding = "0.3.2" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } num-traits = "0.2.15" num-derive = "0.3.3" hex-literal = "0.3.4" diff --git a/actors/evm/Cargo.toml b/actors/evm/Cargo.toml index 156f6e2a01..ff002f9ae3 100644 --- a/actors/evm/Cargo.toml +++ b/actors/evm/Cargo.toml @@ -15,7 +15,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } fvm_ipld_kamt = { version = "0.1.0" } serde = { version = "1.0.136", features = ["derive"] } serde_tuple = "0.5" diff --git a/actors/evm/src/interpreter/system.rs b/actors/evm/src/interpreter/system.rs index 1e62f44d74..42e090d68a 100644 --- a/actors/evm/src/interpreter/system.rs +++ b/actors/evm/src/interpreter/system.rs @@ -222,11 +222,21 @@ impl<'r, RT: Runtime> System<'r, RT> { send_flags: SendFlags, ) -> Result, ActorError> { self.flush()?; - let result = self.rt.send_generalized(to, method, params, value, gas_limit, send_flags)?; + let result = self + .rt + .send_generalized(to, method, params, value, gas_limit, send_flags) + .map_err(|err| actor_error!(unspecified; "send syscall failed: {}", err))?; if !send_flags.read_only() { self.reload()?; } - Ok(result) + match result.exit_code { + ExitCode::OK => Ok(result.return_data), + e => Err(ActorError::unchecked_with_data( + e, + "send failed".to_string(), + result.return_data, + )), + } } /// Flush the actor state (bytecode, nonce, and slots). diff --git a/actors/init/Cargo.toml b/actors/init/Cargo.toml index e43395525b..8579b8e18c 100644 --- a/actors/init/Cargo.toml +++ b/actors/init/Cargo.toml @@ -15,7 +15,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } fvm_ipld_hamt = "0.6.1" frc42_dispatch = "3.0.0" serde = { version = "1.0.136", features = ["derive"] } diff --git a/actors/market/Cargo.toml b/actors/market/Cargo.toml index a3e6d26876..3044d6656a 100644 --- a/actors/market/Cargo.toml +++ b/actors/market/Cargo.toml @@ -24,7 +24,7 @@ fvm_ipld_bitfield = "0.5.2" fvm_ipld_blockstore = "0.1.1" fvm_ipld_encoding = "0.3.2" fvm_ipld_hamt = "0.6.1" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } integer-encoding = { version = "3.0.3", default-features = false } libipld-core = { version = "0.13.1", features = ["serde-codec"] } log = "0.4.14" diff --git a/actors/miner/Cargo.toml b/actors/miner/Cargo.toml index a99953a552..e0fad04d18 100644 --- a/actors/miner/Cargo.toml +++ b/actors/miner/Cargo.toml @@ -16,7 +16,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } frc42_dispatch = "3.0.0" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } fvm_ipld_bitfield = "0.5.4" fvm_ipld_amt = { version = "0.5.0", features = ["go-interop"] } fvm_ipld_hamt = "0.6.1" diff --git a/actors/multisig/Cargo.toml b/actors/multisig/Cargo.toml index 778dfc749d..77adf2e273 100644 --- a/actors/multisig/Cargo.toml +++ b/actors/multisig/Cargo.toml @@ -23,7 +23,7 @@ fvm_actor_utils = "3.0.0" fvm_ipld_blockstore = "0.1.1" fvm_ipld_encoding = "0.3.2" fvm_ipld_hamt = "0.6.1" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } indexmap = { version = "1.8.0", features = ["serde-1"] } integer-encoding = { version = "3.0.3", default-features = false } num-derive = "0.3.3" diff --git a/actors/paych/Cargo.toml b/actors/paych/Cargo.toml index 08e0644657..662e146ec5 100644 --- a/actors/paych/Cargo.toml +++ b/actors/paych/Cargo.toml @@ -15,7 +15,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } frc42_dispatch = "3.0.0" num-traits = "0.2.14" num-derive = "0.3.3" diff --git a/actors/placeholder/Cargo.toml b/actors/placeholder/Cargo.toml index 6032b4fe95..d2f2b76052 100644 --- a/actors/placeholder/Cargo.toml +++ b/actors/placeholder/Cargo.toml @@ -13,8 +13,8 @@ keywords = ["filecoin", "web3", "wasm"] crate-type = ["cdylib", "lib"] [dependencies] -fvm_sdk = { version = "3.0.0-alpha.21", optional = true } -fvm_shared = { version = "3.0.0-alpha.15", optional = true } +fvm_sdk = { version = "3.0.0-alpha.22", optional = true } +fvm_shared = { version = "3.0.0-alpha.16", optional = true } [features] fil-actor = ["fvm_sdk", "fvm_shared"] diff --git a/actors/power/Cargo.toml b/actors/power/Cargo.toml index ed2dfcc457..893ffc8c28 100644 --- a/actors/power/Cargo.toml +++ b/actors/power/Cargo.toml @@ -15,7 +15,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } frc42_dispatch = "3.0.0" fvm_ipld_hamt = "0.6.1" num-traits = "0.2.14" diff --git a/actors/reward/Cargo.toml b/actors/reward/Cargo.toml index 850f75a1d5..e0f45916b3 100644 --- a/actors/reward/Cargo.toml +++ b/actors/reward/Cargo.toml @@ -15,7 +15,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } num-traits = "0.2.14" num-derive = "0.3.3" log = "0.4.14" diff --git a/actors/system/Cargo.toml b/actors/system/Cargo.toml index 5bac8c5762..c1960dbf55 100644 --- a/actors/system/Cargo.toml +++ b/actors/system/Cargo.toml @@ -15,7 +15,7 @@ crate-type = ["cdylib", "lib"] [dependencies] fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../../runtime" } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } fvm_ipld_encoding = "0.3.2" fvm_ipld_blockstore = "0.1.1" num-traits = "0.2.14" diff --git a/actors/verifreg/Cargo.toml b/actors/verifreg/Cargo.toml index d04882911a..065abaec66 100644 --- a/actors/verifreg/Cargo.toml +++ b/actors/verifreg/Cargo.toml @@ -24,7 +24,7 @@ fvm_actor_utils = "3.0.0" fvm_ipld_blockstore = "0.1.1" fvm_ipld_encoding = "0.3.2" fvm_ipld_hamt = "0.6.1" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } lazy_static = "1.4.0" log = "0.4.14" num-derive = "0.3.3" diff --git a/runtime/Cargo.toml b/runtime/Cargo.toml index ba9fb7f75d..4ad059d746 100644 --- a/runtime/Cargo.toml +++ b/runtime/Cargo.toml @@ -10,7 +10,7 @@ repository = "https://github.com/filecoin-project/builtin-actors" [dependencies] fvm_ipld_hamt = "0.6.1" fvm_ipld_amt = { version = "0.5.0", features = ["go-interop"] } -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } num = { version = "0.4", features = ["serde"] } num-traits = "0.2.14" num-derive = "0.3.3" @@ -37,7 +37,7 @@ castaway = "0.2.2" sha2 = "0.10" # fil-actor -fvm_sdk = { version = "3.0.0-alpha.21", optional = true } +fvm_sdk = { version = "3.0.0-alpha.22", optional = true } # test_util rand = { version = "0.8.5", default-features = false, optional = true } @@ -90,4 +90,4 @@ no-provider-deal-collateral = [] # fake proofs (for testing) fake-proofs = [] -test_utils = ["hex", "multihash/sha2", "libsecp256k1", "blake2b_simd", "rand", "rand/std_rng", "lazy_static", "pretty_env_logger"] +test_utils = ["hex", "multihash/sha2", "libsecp256k1", "blake2b_simd", "rand", "rand/std_rng", "lazy_static", "pretty_env_logger"] \ No newline at end of file diff --git a/runtime/src/runtime/fvm.rs b/runtime/src/runtime/fvm.rs index 7205e4c8a0..d61476ca2b 100644 --- a/runtime/src/runtime/fvm.rs +++ b/runtime/src/runtime/fvm.rs @@ -24,6 +24,7 @@ use fvm_shared::sector::{ }; use fvm_shared::sys::SendFlags; use fvm_shared::version::NetworkVersion; +use fvm_shared::Response; use fvm_shared::{ActorID, MethodNum}; use num_traits::FromPrimitive; use serde::de::DeserializeOwned; @@ -318,69 +319,12 @@ where value: TokenAmount, gas_limit: Option, flags: SendFlags, - ) -> Result, ActorError> { + ) -> Result { if self.in_transaction { - return Err(actor_error!(assertion_failed; "send is not allowed during transaction")); + return Err(ErrorNumber::IllegalOperation); } - match fvm::send::send(to, method, params, value, gas_limit, flags) { - Ok(ret) => { - if ret.exit_code.is_success() { - Ok(ret.return_data) - } else { - // The returned code can't be simply propagated as it may be a system exit code. - // TODO: improve propagation once we return a RuntimeError. - // Ref https://github.com/filecoin-project/builtin-actors/issues/144 - let exit_code = match ret.exit_code { - // This means the called actor did something wrong. We can't "make up" a - // reasonable exit code. - ExitCode::SYS_MISSING_RETURN - | ExitCode::SYS_ILLEGAL_INSTRUCTION - | ExitCode::SYS_ILLEGAL_EXIT_CODE => ExitCode::USR_UNSPECIFIED, - // We don't expect any other system errors. - code if code.is_system_error() => ExitCode::USR_ASSERTION_FAILED, - // Otherwise, pass it through. - code => code, - }; - Err(ActorError::unchecked_with_data( - exit_code, - format!( - "send to {} method {} aborted with code {}", - to, method, ret.exit_code - ), - ret.return_data, - )) - } - } - Err(err) => Err(match err { - // Some of these errors are from operations in the Runtime or SDK layer - // before or after the underlying VM send syscall. - ErrorNumber::NotFound => { - // This means that the receiving actor doesn't exist. - // TODO: we can't reasonably determine the correct "exit code" here. - actor_error!(unspecified; "receiver not found") - } - ErrorNumber::InsufficientFunds => { - // This means that the send failed because we have insufficient funds. We will - // get a _syscall error_, not an exit code, because the target actor will not - // run (and therefore will not exit). - actor_error!(insufficient_funds; "not enough funds") - } - ErrorNumber::LimitExceeded => { - // This means we've exceeded the recursion limit. - // TODO: Define a better exit code. - actor_error!(assertion_failed; "recursion limit exceeded") - } - ErrorNumber::ReadOnly => ActorError::unchecked( - ExitCode::USR_READ_ONLY, - "attempted to mutate state while in readonly mode".into(), - ), - err => { - // We don't expect any other syscall exit codes. - actor_error!(assertion_failed; "unexpected error: {}", err) - } - }), - } + fvm::send::send(to, method, params, value, gas_limit, flags) } fn new_actor_address(&mut self) -> Result { diff --git a/runtime/src/runtime/mod.rs b/runtime/src/runtime/mod.rs index 7d874ffb7e..75422bf331 100644 --- a/runtime/src/runtime/mod.rs +++ b/runtime/src/runtime/mod.rs @@ -49,6 +49,8 @@ pub(crate) mod empty; pub use empty::EMPTY_ARR_CID; use fvm_ipld_encoding::ipld_block::IpldBlock; +use fvm_shared::error::{ErrorNumber, ExitCode}; +use fvm_shared::Response; /// Runtime is the VM's internal runtime object. /// this is everything that is accessible to actors, beyond parameters. @@ -196,7 +198,64 @@ pub trait Runtime: Primitives + Verifier + RuntimePolicy { params: Option, value: TokenAmount, ) -> Result, ActorError> { - self.send_generalized(to, method, params, value, None, SendFlags::empty()) + match self.send_generalized(to, method, params, value, None, SendFlags::empty()) { + Ok(ret) => { + if ret.exit_code.is_success() { + Ok(ret.return_data) + } else { + // The returned code can't be simply propagated as it may be a system exit code. + // TODO: improve propagation once we return a RuntimeError. + // Ref https://github.com/filecoin-project/builtin-actors/issues/144 + let exit_code = match ret.exit_code { + // This means the called actor did something wrong. We can't "make up" a + // reasonable exit code. + ExitCode::SYS_MISSING_RETURN + | ExitCode::SYS_ILLEGAL_INSTRUCTION + | ExitCode::SYS_ILLEGAL_EXIT_CODE => ExitCode::USR_UNSPECIFIED, + // We don't expect any other system errors. + code if code.is_system_error() => ExitCode::USR_ASSERTION_FAILED, + // Otherwise, pass it through. + code => code, + }; + Err(ActorError::unchecked_with_data( + exit_code, + format!( + "send to {} method {} aborted with code {}", + to, method, ret.exit_code + ), + ret.return_data, + )) + } + } + Err(err) => Err(match err { + // Some of these errors are from operations in the Runtime or SDK layer + // before or after the underlying VM send syscall. + ErrorNumber::NotFound => { + // This means that the receiving actor doesn't exist. + // TODO: we can't reasonably determine the correct "exit code" here. + actor_error!(unspecified; "receiver not found") + } + ErrorNumber::InsufficientFunds => { + // This means that the send failed because we have insufficient funds. We will + // get a _syscall error_, not an exit code, because the target actor will not + // run (and therefore will not exit). + actor_error!(insufficient_funds; "not enough funds") + } + ErrorNumber::LimitExceeded => { + // This means we've exceeded the recursion limit. + // TODO: Define a better exit code. + actor_error!(assertion_failed; "recursion limit exceeded") + } + ErrorNumber::ReadOnly => ActorError::unchecked( + ExitCode::USR_READ_ONLY, + "attempted to mutate state while in readonly mode".into(), + ), + err => { + // We don't expect any other syscall exit codes. + actor_error!(assertion_failed; "unexpected error: {}", err) + } + }), + } } /// Generalizes [`Runtime::send`] and [`Runtime::send_read_only`] to allow the caller to @@ -209,7 +268,7 @@ pub trait Runtime: Primitives + Verifier + RuntimePolicy { value: TokenAmount, gas_limit: Option, flags: SendFlags, - ) -> Result, ActorError>; + ) -> Result; /// Computes an address for a new actor. The returned address is intended to uniquely refer to /// the actor even in the event of a chain re-org (whereas an ID-address might refer to a diff --git a/runtime/src/test_utils.rs b/runtime/src/test_utils.rs index eb18df3de7..14320c1b44 100644 --- a/runtime/src/test_utils.rs +++ b/runtime/src/test_utils.rs @@ -22,7 +22,7 @@ use fvm_shared::crypto::signature::{ Signature, SECP_PUB_LEN, SECP_SIG_LEN, SECP_SIG_MESSAGE_HASH_SIZE, }; use fvm_shared::econ::TokenAmount; -use fvm_shared::error::ExitCode; +use fvm_shared::error::{ErrorNumber, ExitCode}; use fvm_shared::piece::PieceInfo; use fvm_shared::randomness::RANDOMNESS_LENGTH; use fvm_shared::sector::{ @@ -31,7 +31,7 @@ use fvm_shared::sector::{ }; use fvm_shared::sys::SendFlags; use fvm_shared::version::NetworkVersion; -use fvm_shared::{ActorID, MethodNum}; +use fvm_shared::{ActorID, MethodNum, Response}; use multihash::derive::Multihash; use multihash::MultihashDigest; @@ -1130,11 +1130,11 @@ impl Runtime for MockRuntime { value: TokenAmount, gas_limit: Option, send_flags: SendFlags, - ) -> Result, ActorError> { + ) -> Result { // TODO gas_limit is currently ignored, what should we do about it? self.require_in_call(); if self.in_transaction { - return Err(actor_error!(assertion_failed; "side-effect within transaction")); + return Ok(Response { exit_code: ExitCode::USR_ASSERTION_FAILED, return_data: None }); } assert!( @@ -1176,22 +1176,12 @@ impl Runtime for MockRuntime { { let mut balance = self.balance.borrow_mut(); if value > *balance { - return Err(ActorError::unchecked( - ExitCode::SYS_SENDER_STATE_INVALID, - format!("cannot send value: {:?} exceeds balance: {:?}", value, *balance), - )); + return Err(ErrorNumber::InsufficientFunds); } *balance -= value; } - match expected_msg.exit_code { - ExitCode::OK => Ok(expected_msg.send_return), - x => Err(ActorError::unchecked_with_data( - x, - "Expected message Fail".to_string(), - expected_msg.send_return, - )), - } + Ok(Response { exit_code: expected_msg.exit_code, return_data: expected_msg.send_return }) } fn new_actor_address(&mut self) -> Result { diff --git a/state/Cargo.toml b/state/Cargo.toml index 364c05eea4..46862107bc 100644 --- a/state/Cargo.toml +++ b/state/Cargo.toml @@ -27,7 +27,7 @@ fil_actor_reward = { version = "10.0.0-alpha.1", path = "../actors/reward"} fil_actor_system = { version = "10.0.0-alpha.1", path = "../actors/system"} fil_actor_init = { version = "10.0.0-alpha.1", path = "../actors/init"} fil_actors_runtime = { version = "10.0.0-alpha.1", path = "../runtime"} -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } fvm_ipld_encoding = "0.3.2" frc46_token = "3.0.0" fvm_ipld_blockstore = "0.1.1" diff --git a/test_vm/Cargo.toml b/test_vm/Cargo.toml index aa24cf2b2f..c14b99eff6 100644 --- a/test_vm/Cargo.toml +++ b/test_vm/Cargo.toml @@ -39,7 +39,7 @@ fvm_ipld_bitfield = "0.5.4" fvm_ipld_blockstore = { version = "0.1.1", default-features = false } fvm_ipld_encoding = { version = "0.3.2", default-features = false } fvm_ipld_hamt = "0.6.1" -fvm_shared = { version = "3.0.0-alpha.15", default-features = false } +fvm_shared = { version = "3.0.0-alpha.16", default-features = false } indexmap = { version = "1.8.0", features = ["serde-1"] } integer-encoding = { version = "3.0.3", default-features = false } lazy_static = "1.4.0" diff --git a/test_vm/src/lib.rs b/test_vm/src/lib.rs index 40c997e07e..d9777baaf5 100644 --- a/test_vm/src/lib.rs +++ b/test_vm/src/lib.rs @@ -49,7 +49,7 @@ use fvm_shared::crypto::signature::{ Signature, SECP_PUB_LEN, SECP_SIG_LEN, SECP_SIG_MESSAGE_HASH_SIZE, }; use fvm_shared::econ::TokenAmount; -use fvm_shared::error::ExitCode; +use fvm_shared::error::{ErrorNumber, ExitCode}; use fvm_shared::event::ActorEvent; use fvm_shared::piece::PieceInfo; use fvm_shared::randomness::Randomness; @@ -61,7 +61,7 @@ use fvm_shared::sector::{ use fvm_shared::smooth::FilterEstimate; use fvm_shared::sys::SendFlags; use fvm_shared::version::NetworkVersion; -use fvm_shared::{ActorID, MethodNum, IPLD_RAW, METHOD_CONSTRUCTOR, METHOD_SEND}; +use fvm_shared::{ActorID, MethodNum, Response, IPLD_RAW, METHOD_CONSTRUCTOR, METHOD_SEND}; use regex::Regex; use serde::de::DeserializeOwned; use serde::{ser, Serialize}; @@ -998,7 +998,7 @@ impl<'invocation, 'bs> Runtime for InvocationCtx<'invocation, 'bs> { value: TokenAmount, _gas_limit: Option, mut send_flags: SendFlags, - ) -> Result, ActorError> { + ) -> Result { // replicate FVM by silently propagating read only flag to subcalls if self.read_only() { send_flags.set(SendFlags::READ_ONLY, true) @@ -1006,10 +1006,7 @@ impl<'invocation, 'bs> Runtime for InvocationCtx<'invocation, 'bs> { // TODO gas_limit is current ignored, what should we do about it? if !self.allow_side_effects { - return Err(ActorError::unchecked( - ExitCode::SYS_ASSERTION_FAILED, - "Calling send is not allowed during side-effect lock".to_string(), - )); + return Ok(Response { exit_code: ExitCode::SYS_ASSERTION_FAILED, return_data: None }); } let new_actor_msg = InternalMessage { from: self.to(), to: *to, value, method, params }; @@ -1030,7 +1027,10 @@ impl<'invocation, 'bs> Runtime for InvocationCtx<'invocation, 'bs> { subinvocs.push(invoc); subinvocs }); - res + Ok(Response { + exit_code: res.clone().map_or_else(|e| e.exit_code(), |_| ExitCode::OK), + return_data: res.map_or_else(|mut e| e.take_data(), |r| r), + }) } fn get_randomness_from_tickets(