fix: handle isexist error for IsDirectDeal column in migration #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Oct 20, 2023
Comment on lines
18
to
19
| errorStr := strings.Split(err.Error(), ";") | ||
| if strings.Compare("code=2200", errorStr[0]) == 0 { |
There was a problem hiding this comment.
I'd relax this directly to strings.Contains
Suggested change
| errorStr := strings.Split(err.Error(), ";") | |
| if strings.Compare("code=2200", errorStr[0]) == 0 { | |
| if strings.Contains(err.Error(), "code=2200") { |
nonsense
approved these changes
Oct 20, 2023
LexLuthr
force-pushed
the
fix/cql-migration
branch
from
ebf2c46 to
753e371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1754