Skip to content

Conversation

@LexLuthr
Copy link
Collaborator

This version of boost-graphsync contains the below 2 fixes.

Handle context cancellation properly (ipfs/go-graphsync#428) by @hannahhoward in filecoin-project/boost-graphsync#2
fix: update go-ipld-prime, don't slurp bytes on non-match visit by @rvagg in filecoin-project/boost-graphsync#3

@LexLuthr LexLuthr requested a review from dirkmc August 25, 2023 08:11
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @LexLuthr

I think @rvagg is planning to add some tests also before merge.

@LexLuthr
Copy link
Collaborator Author

I will hold off on merging till @rvagg is finished adding the tests.

@LexLuthr LexLuthr requested a review from dirkmc August 29, 2023 11:12
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @rvagg

@LexLuthr LexLuthr merged commit 4ce0c4b into main Aug 29, 2023
@LexLuthr LexLuthr deleted the bump-b-graphsync branch August 29, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants