Skip to content

feat: add docker to containerize a standalone boost-client #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 16, 2023
Merged

feat: add docker to containerize a standalone boost-client #1616

merged 6 commits into from
Aug 16, 2023

Conversation

@alvin-reyes
Copy link

@alvin-reyes alvin-reyes commented Aug 14, 2023 •
edited by LexLuthr
Loading

Fixes #1550

Changes

  • Added a dockerfile for boost client.
  • Add some entrypoint.sh and a few commands to run when the container runs.

@dirkmc dirkmc requested a review from LexLuthr August 14, 2023 08:59
nonsense
nonsense reviewed Aug 14, 2023
View reviewed changes
LexLuthr
LexLuthr previously requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to clean up sample deal making as we don't have all binaries for it. The init script is also not required.

docker/boost-client/Dockerfile.source Outdated

RUN --mount=type=cache,target=/root/.cache/go-build \
--mount=type=cache,target=/go/pkg/mod \
make debug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use make build

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved on the latest commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LexLuthr, should we use make boost instead?

@LexLuthr
Update docker/boost-client/Dockerfile.source
55b7d77 
thank you!

Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>
@alvin-reyes alvin-reyes marked this pull request as ready for review August 15, 2023 07:44
@alvin-reyes alvin-reyes dismissed LexLuthr’s stale review August 15, 2023 11:29

resolved on the latest commit.

LexLuthr
LexLuthr reviewed Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now. Can you build the image for both Linux and MacOS once and try to run them alongside an already running devnet? If everything looks okay, then please make a deal and retrieve from this new container.

@alvin-reyes
Copy link
Author

Built and ran on Ubuntu

  • Build successful
  • I was able to run devnet and made a deal.
image

I had to run boostx market-add to put some FIL in.

boost deal --verified=false --provider=t01000 --http-url=http://demo-http-server/sample.car --commp=baga6ea4seaqpfonfro6j3gcw4uxkxbivlqn2fghx5dpulc6sbi5noz7bcvzmuiq --car-size=1175 --piece-size=2048 --payload-cid=bafk2bzacec3jst4tkh424chatp273o6rxvipfg54kphd56gaxobpcdtr2sgco --storage-price 20000000000

Build and ran on MacOs

  • Build successful
  • I was able to run devnet and made a deal.
image

I had to run boostx market-add to put some FIL in.

boost deal --verified=false --provider=t01000 --http-url=http://demo-http-server/sample.car --commp=baga6ea4seaqpfonfro6j3gcw4uxkxbivlqn2fghx5dpulc6sbi5noz7bcvzmuiq --car-size=1175 --piece-size=2048 --payload-cid=bafk2bzacec3jst4tkh424chatp273o6rxvipfg54kphd56gaxobpcdtr2sgco --storage-price 20000000000

@LexLuthr LexLuthr merged commit 8818d91 into filecoin-project:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

@nonsense nonsense Awaiting requested review from nonsense

Assignees

@alvin-reyes alvin-reyes

Labels

None yet

Projects

Boost
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dockerfile for boost client

3 participants

@alvin-reyes @nonsense @LexLuthr