Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Funds page and tagging functionality #726

Open
nonsense opened this issue Aug 24, 2022 · 0 comments
Open

Refactor Funds page and tagging functionality #726

nonsense opened this issue Aug 24, 2022 · 0 comments
Labels

Comments

@nonsense
Copy link
Member

At the moment in Boost we have Funds tagging functionality (for PublishStorageDeals message and for deal collateral) as well as an overview of a few wallets and functionality to move funds to escrow for deal collateral.

While this is somewhat informative and provides some visibility over what funds an SP must hold to accept deals, it is unfortunately not an exhaustive set of required funds, and we can't make a decision whether to accept/reject a deal just on that information.

The idea behind the Funds page and feature was to tag/untag funds and have a high confidence that the SP has enough funds for the deal to be put on chain into a sector and the sector to be continuously proven. We can't achieve this without tapping into wallets configured on lotus-miner side and coding various heuristics in order to make a decision whether a deal can be accepted/rejected


Because of the complexity described above, after a chat with Dirk, we have decided that we should refactor the Funds functionality in the following way:

  • display read-only information about all control and worker and owner wallets from lotus-miner
  • continue to display information about deal collateral and market escrow
  • remove functionality for tagging/untagging of funds when accepting deals

Ultimately for now it will be up to the user to maintain funds in all relevant wallets, so that deals are accepted and stored successfully on the miner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants