Skip to content

Commit ced78b5

Browse files
richardo2016xicilion
authored andcommitted
tools, feat: add .github/PULL_REQUEST_TEMPLATE.md (#439)
1 parent 1adbf8d commit ced78b5

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
Please fill in this template.
2+
3+
- [ ] Use a meaningful title for the pull request with prefix '(module|object|source_directory) [bugfix|feat|refactor|]', Such as `db, bugfix: ...`, `tools, feat: ...`
4+
- [ ] Test the change in your own code. (Compile and run.)
5+
- [ ] Add or edit tests to reflect the change. (Run with `fibjs test`.)
6+
- [ ] Ensure commits history clean, merge master/dev and clean meaningless commits by `git rebase`.
7+
8+
Select type of change you made and delete the others:
9+
10+
If adding/changing one existing module or internal Object:
11+
- [ ] Add/Change the corresponding `*.idl` file
12+
- [ ] Run `fibjs ./tools/idlc.js` to auto-generate `*.h`, **never change it**
13+
14+
If removing one existing module or internal Object:
15+
- [ ] Remove corresponding `*.h`, `*.idl`, `*.cpp`
16+
- [ ] Remove all reference to it.
17+
18+
If adding internal js scripts:
19+
- [ ] Add it to `fibjs/scripts`
20+
- [ ] Run `fibjs ./tools/gen_script.js`

0 commit comments

Comments
 (0)