Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support byte arrays #94

Closed
arendjr opened this issue Apr 4, 2022 · 0 comments · Fixed by #132
Closed

Support byte arrays #94

arendjr opened this issue Apr 4, 2022 · 0 comments · Fixed by #132
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arendjr
Copy link
Contributor

arendjr commented Apr 4, 2022

The OpenTelemetry log standard, which we are basing the log format in the provider protocol on, uses 16-byte arrays for the TraceId and SpanId. In order to correctly add these fields to the protocol, fp-bindgen needs to support byte arrays.

Alternatives

  • Use Vec<u8> ID types - this is possible but less than ideal because we need to check that the array is the correct length
  • Use String ID types - also less than ideal because we need to check the format and need to ensure that IDs are represented consistently (upper/lower case and with/without dashes)
  • Support the UUID type - the TraceId and SpanId do not necessarily need to be valid UUIDs, so this is not a good solution for this use case.

cc @Zagitta @emschwartz

@arendjr arendjr added the enhancement New feature or request label Apr 4, 2022
@arendjr arendjr added the good first issue Good for newcomers label Jun 21, 2022
@sagacity sagacity self-assigned this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants