yiisoft#58: Deleting failed jobs from queue

Author: zhuravljov

CHANGELOG.md

@@ -1,8 +1,9 @@
 Yii2 Queue Extension Change Log
 ===============================
 
-## 1.0.1 under development
+## 1.0.1
 
+- Enh #58: Deleting failed jobs from queue
 - Enh #55: Job priority
 
 ## 1.0.0

src/drivers/beanstalk/Queue.php

@@ -48,10 +48,9 @@ class Queue extends CliQueue
      */
     public function run()
     {
-        while ($message = $this->getPheanstalk()->reserveFromTube($this->tube, 0)) {
-            if ($this->handleMessage($message->getId(), $message->getData())) {
-                $this->getPheanstalk()->delete($message);
-            }
+        while ($payload = $this->getPheanstalk()->reserveFromTube($this->tube, 0)) {
+            $this->handleMessage($payload->getId(), $payload->getData());
+            $this->getPheanstalk()->delete($payload);
         }
     }
 
@@ -62,9 +61,8 @@ public function listen()
     {
         while (!Signal::isExit()) {
             if ($payload = $this->getPheanstalk()->reserveFromTube($this->tube, 3)) {
-                if ($this->handleMessage($payload->getId(), $payload->getData())) {
-                    $this->getPheanstalk()->delete($payload);
-                }
+                $this->handleMessage($payload->getId(), $payload->getData());
+                $this->getPheanstalk()->delete($payload);
             }
         }
     }