Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer to (co)maintain this gem #3

Closed
dblock opened this issue Jan 5, 2018 · 10 comments
Closed

Offer to (co)maintain this gem #3

dblock opened this issue Jan 5, 2018 · 10 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Jan 5, 2018

Hi @jaap & @koenpunt.

I'm coming via codegram/hyperclient#129, am co-maintainer of Hyperclient, https://github.com/ruby-grape/grape, https://github.com/intridea/hashie and more.

Can I/we please help with faraday_hal_middleware? We'd like to get some PRs merged (#1 and #2) and generally move this forward. I'll happily take over maintenance and maybe @espen would like to join too.

I'm dblock[at]dblock[dot]org for Rubygems.

@dblock dblock changed the title Offer to maintain this gem Offer to (co)maintain this gem Jan 5, 2018
@espen
Copy link
Collaborator

espen commented Jan 10, 2018

I'm not that familiar with faraday but can assist with responding to and fixing basic issues like the ones I reported and made pull requests for.

@koenpunt
Copy link
Contributor

Hi @dblock, thanks for your interest. I've just merged and released the 2 pending pull requests. But since I'm not actively using this gem I'm fine with adding you as a contributor (which I just did).

@dblock
Copy link
Collaborator Author

dblock commented Jan 10, 2018

Amazing, thanks @koenpunt. Care to add me to Rubygems too and you don't have to worry about this one for a while at least anymore?

@koenpunt
Copy link
Contributor

So eager you are ;) Just added you there too!

@dblock
Copy link
Collaborator Author

dblock commented Jan 10, 2018

I am just trying to reduce bus factor :) Can we add @espen too? He has been helping with hyperclient quite a bit.

@dblock
Copy link
Collaborator Author

dblock commented Jan 10, 2018

Last question: do you care to PR/merge changes or can we just run with this since you're not using it?

@dblock dblock closed this as completed Jan 10, 2018
@koenpunt
Copy link
Contributor

@espen is added too.

Last question: do you care to PR/merge changes or can we just run with this?

What do you mean? As in still wanting to have a voice in new PRs? Not really. Also I doubt that the API surface will change anytime soon, so I don't expect any major changes anyway. But I'll probably have a look at anything that comes by, so if I feel the need you'll hear from me.

All I can say, good luck with it :)

@dblock
Copy link
Collaborator Author

dblock commented Jan 10, 2018

Right on. We'll keep this alive since it has been a dependency for a very popular hyperclient. Thanks for making the gem and say hi if you're in NY I'll buy you a drink or ten.

@koenpunt
Copy link
Contributor

Cool, when I'll cross the pond someday again!

it has been a dependency for a very popular hyperclient

Now I remember; I actually created this Gem for use with Hyperclient 🙃(codegram/hyperclient@9e81da5)

@dblock
Copy link
Collaborator Author

dblock commented Jan 10, 2018

Haha awesome. One last piece of help in enabling travis pls, #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants