Skip to content

Commit e7dd9c7

Browse files
committed
Merge branch 'PHP-7.1' into PHP-7.2
* PHP-7.1: Update NEWS Fixed bug #75049 (spl_autoload_unregister can't handle spl_autoload_functions results)
2 parents 823ca5c + 46ecda7 commit e7dd9c7

File tree

2 files changed

+32
-4
lines changed

2 files changed

+32
-4
lines changed

ext/spl/php_spl.c

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -564,8 +564,14 @@ PHP_FUNCTION(spl_autoload_register)
564564
ZSTR_VAL(lc_name)[ZSTR_LEN(lc_name)] = '\0';
565565
} else {
566566
ZVAL_UNDEF(&alfi.closure);
567-
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
568-
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
567+
/* Skip leading \ */
568+
if (ZSTR_VAL(func_name)[0] == '\\') {
569+
lc_name = zend_string_alloc(ZSTR_LEN(func_name) - 1, 0);
570+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name) + 1, ZSTR_LEN(func_name) - 1);
571+
} else {
572+
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
573+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
574+
}
569575
}
570576
zend_string_release(func_name);
571577

@@ -683,8 +689,14 @@ PHP_FUNCTION(spl_autoload_unregister)
683689
memcpy(ZSTR_VAL(lc_name) + ZSTR_LEN(func_name), &Z_OBJ_HANDLE_P(zcallable), sizeof(uint32_t));
684690
ZSTR_VAL(lc_name)[ZSTR_LEN(lc_name)] = '\0';
685691
} else {
686-
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
687-
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
692+
/* Skip leading \ */
693+
if (ZSTR_VAL(func_name)[0] == '\\') {
694+
lc_name = zend_string_alloc(ZSTR_LEN(func_name) - 1, 0);
695+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name) + 1, ZSTR_LEN(func_name) - 1);
696+
} else {
697+
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
698+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
699+
}
688700
}
689701
zend_string_release(func_name);
690702

ext/spl/tests/bug75049.phpt

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
--TEST--
2+
Bug #75049 (spl_autoload_unregister can't handle spl_autoload_functions results)
3+
--FILE--
4+
<?php
5+
class Auto { public static function loader() {}}
6+
$autoloader = '\Auto::loader';
7+
8+
echo (int)spl_autoload_register($autoloader);
9+
echo (int)spl_autoload_unregister($autoloader);
10+
echo (int)spl_autoload_register($autoloader);
11+
foreach (spl_autoload_functions() as $loader) {
12+
echo (int)spl_autoload_unregister($loader);
13+
}
14+
echo (int)count(spl_autoload_functions());
15+
--EXPECTF--
16+
11110

0 commit comments

Comments
 (0)