Skip to content

Commit 307acb6

Browse files
committed
Merge branch 'PHP-7.0' into PHP-7.1
* PHP-7.0: Fixed bug #75049 (spl_autoload_unregister can't handle spl_autoload_functions results)
2 parents 42608a3 + b06f8cb commit 307acb6

File tree

2 files changed

+32
-4
lines changed

2 files changed

+32
-4
lines changed

ext/spl/php_spl.c

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -535,8 +535,14 @@ PHP_FUNCTION(spl_autoload_register)
535535
ZSTR_VAL(lc_name)[ZSTR_LEN(lc_name)] = '\0';
536536
} else {
537537
ZVAL_UNDEF(&alfi.closure);
538-
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
539-
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
538+
/* Skip leading \ */
539+
if (ZSTR_VAL(func_name)[0] == '\\') {
540+
lc_name = zend_string_alloc(ZSTR_LEN(func_name) - 1, 0);
541+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name) + 1, ZSTR_LEN(func_name) - 1);
542+
} else {
543+
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
544+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
545+
}
540546
}
541547
zend_string_release(func_name);
542548

@@ -654,8 +660,14 @@ PHP_FUNCTION(spl_autoload_unregister)
654660
memcpy(ZSTR_VAL(lc_name) + ZSTR_LEN(func_name), &Z_OBJ_HANDLE_P(zcallable), sizeof(uint32_t));
655661
ZSTR_VAL(lc_name)[ZSTR_LEN(lc_name)] = '\0';
656662
} else {
657-
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
658-
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
663+
/* Skip leading \ */
664+
if (ZSTR_VAL(func_name)[0] == '\\') {
665+
lc_name = zend_string_alloc(ZSTR_LEN(func_name) - 1, 0);
666+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name) + 1, ZSTR_LEN(func_name) - 1);
667+
} else {
668+
lc_name = zend_string_alloc(ZSTR_LEN(func_name), 0);
669+
zend_str_tolower_copy(ZSTR_VAL(lc_name), ZSTR_VAL(func_name), ZSTR_LEN(func_name));
670+
}
659671
}
660672
zend_string_release(func_name);
661673

ext/spl/tests/bug75049.phpt

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
--TEST--
2+
Bug #75049 (spl_autoload_unregister can't handle spl_autoload_functions results)
3+
--FILE--
4+
<?php
5+
class Auto { public static function loader() {}}
6+
$autoloader = '\Auto::loader';
7+
8+
echo (int)spl_autoload_register($autoloader);
9+
echo (int)spl_autoload_unregister($autoloader);
10+
echo (int)spl_autoload_register($autoloader);
11+
foreach (spl_autoload_functions() as $loader) {
12+
echo (int)spl_autoload_unregister($loader);
13+
}
14+
echo (int)count(spl_autoload_functions());
15+
--EXPECTF--
16+
11110

0 commit comments

Comments
 (0)