Skip to content

Commit 84f5245

Browse files
committed
perf: small performance improvement avoiding Array#unshift
1 parent 1dd6ec5 commit 84f5245

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lib/feedsub.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,9 @@ module.exports = class FeedReader extends EventEmitter {
122122
const success = (abort) => {
123123
if (ended) { return; }
124124
ended = true;
125+
if (sortOrder <= 0) {
126+
newItems.reverse();
127+
}
125128
this.news.addHistory('item', newItems.map((item) => [item]));
126129
if (this.first && !this.options.emitOnStart) {
127130
newItems = [];
@@ -260,11 +263,11 @@ module.exports = class FeedReader extends EventEmitter {
260263

261264
const getOlderItem = (item) => {
262265
if (this.first) {
263-
newItems.unshift(item);
266+
newItems.push(item);
264267
} else if (!ended) {
265268
let emitted = this.news.emit('item', item);
266269
if (emitted) {
267-
newItems.unshift(item);
270+
newItems.push(item);
268271
} else {
269272
// Check if this item has already been read in previous requests
270273
// if it has, then stop parsing the rest of the document.

0 commit comments

Comments
 (0)