fix: update miniget, fixing write after end error

closes #53

Author: fent

lib/feedsub.js

@@ -97,29 +97,23 @@ module.exports = class FeedReader extends EventEmitter {
    */
   read(callback) {
     let ended = false;
-    let aborted = false;
     let req;
     let items = [];
     let newItems = [];
     let sortOrder = 0;
 
-    const error = (abort, err) => {
+    const error = (err) => {
       ended = true;
       this.first = false;
-      if (!aborted) {
-        if (typeof callback === 'function') {
-          callback(err);
-        } else {
-          this.emit('error', err);
-        }
-      }
-      if (abort && !aborted) {
-        aborted = true;
-        req.abort();
+      if (typeof callback === 'function') {
+        callback(err);
+      } else {
+        this.emit('error', err);
       }
+      req.destroy();
     };
 
-    const success = (abort) => {
+    const success = () => {
       if (ended) { return; }
       ended = true;
       if (sortOrder <= 0) {
@@ -131,9 +125,8 @@ module.exports = class FeedReader extends EventEmitter {
       }
       newItems.forEach(this.emit.bind(this, 'item'));
       this.emit('items', newItems);
-      if (abort && !aborted) {
-        aborted = true;
-        req.abort();
+      if (req) {
+        req.destroy();
       }
       if (typeof callback === 'function') {
         callback(null, newItems);
@@ -184,7 +177,7 @@ module.exports = class FeedReader extends EventEmitter {
 
       // Create feed parser.
       const parser = new FeedMe();
-      parser.on('error', error.bind(null, true));
+      parser.on('error', error);
 
       // Try to get date from one of the fields.
       parser.once('pubdate', getdate);
@@ -272,7 +265,7 @@ module.exports = class FeedReader extends EventEmitter {
             // Check if this item has already been read in previous requests
             // if it has, then stop parsing the rest of the document.
             parser.removeListener('item', getItem);
-            success(true);
+            success();
           }
         }
       };
@@ -304,6 +297,6 @@ module.exports = class FeedReader extends EventEmitter {
       req.on('end', onEnd);
     });
 
-    req.on('error', error.bind(null, false));
+    req.on('error', error);
   }
 };

package-lock.json

@@ -23,7 +23,7 @@
   },
   "dependencies": {
     "feedme": "^1.2.0",
-    "miniget": "^2.0.0",
+    "miniget": "^3.0.0",
     "newsemitter": "^1.0.0"
   },
   "devDependencies": {