Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating a png freezes the cropbox #241

Closed
RHinderiks opened this issue Oct 12, 2017 · 10 comments
Closed

Rotating a png freezes the cropbox #241

RHinderiks opened this issue Oct 12, 2017 · 10 comments

Comments

@RHinderiks
Copy link

RHinderiks commented Oct 12, 2017

Mac OS Sierra
Windows 10

chrome,firefox,safari,edge. all latest version

When rotating an PNG file the cropbox holds the image (so moving the cropbox around does nothing). When rotating an jpeg this works fine.

screen shot 2017-10-12 at 11 21 45
screen shot 2017-10-12 at 11 21 56

@haydar100
Copy link

haydar100 commented Oct 12, 2017

same issue +1

@zhengx666
Copy link

same issue +1

The version v1.0.0 can execute normally.

@fengyuanchen
Copy link
Owner

Can not reappear... Any more detail?

@RHinderiks
Copy link
Author

@fengyuanchen Looking at the code there seems to be a hard reference to jpg in the rotate function. Other than that it it just sticks inside the cropbox after rotate. On your website however it seems to work but the source of the image is a blob there whilst my source is a base64 of a png

@Yusoo
Copy link

Yusoo commented Oct 17, 2017

+1

1 similar comment
@LeeBelieve
Copy link

+1

@fengyuanchen
Copy link
Owner

Maybe it is the problem of some specific images, who can provide one for test?

@RHinderiks
Copy link
Author

RHinderiks commented Oct 19, 2017

@fengyuanchen We used the same image on your website and it works fine but you use a blob source and not a base64 source

@Maia-Everett
Copy link

Happens for me too.

Based on my testing, the regression was introduced in cropper 3.1.0/cropperjs 1.1.0. Previous versions 3.0.0/1.0.0 work fine.

I found a way to reproduce it on the demo page https://fengyuanchen.github.io/cropper/

  1. Open in new tab
  2. Toggle Options -> uncheck scalable
  3. Press one of the rotate buttons

Breaks for me in latest Firefox and Chrome.

screenshot_20171019_184300

@fengyuanchen
Copy link
Owner

@lucidfox Got it! Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants