Skip to content

Commit 67d9ff3

Browse files
anderscarlingPieter de Bie
authored and
Pieter de Bie
committed
WebController: Set JS Controller after reloading the view
The WebKit delegate method didStartProvisionalLoadForFrame: is not called when reloading the frame. This caused the webviews to appear empty. We fix it by using a delegate method which is called each reload, as suggested by weinig in #webkit. This fixes Lighthouse bug brotherbard#81.
1 parent 2812762 commit 67d9ff3

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

PBWebController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ - (void) closeView
5454

5555
# pragma mark Delegate methods
5656

57-
- (void)webView:(WebView *)sender didStartProvisionalLoadForFrame:(WebFrame *)frame
57+
- (void)webView:(WebView *)sender didClearWindowObject:(WebScriptObject *)windowObject forFrame:(WebFrame *)frame
5858
{
5959
id script = [view windowScriptObject];
6060
[script setValue: self forKey:@"Controller"];

PBWebHistoryController.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ - (void) awakeFromNib
2222

2323
- (void) didLoad
2424
{
25+
currentSha = @"";
2526
[self changeContentTo: historyController.webCommit];
2627
}
2728

0 commit comments

Comments
 (0)