PULSEDEV-00000 feedzai-openml: Include release process in README #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
Coverage 84.82% 84.82%
Complexity 281 281
=========================================
Files 38 38
Lines 738 738
Branches 69 69
=========================================
Hits 626 626
Misses 79 79
Partials 33 33 |
waldyrious
reviewed
Feb 17, 2022
|
|
||
| ## Releasing | ||
|
|
||
| If the hotfix branch is ready, you needed to create an annotated tag pointing to the hotfix branch head (example below for releasing version 1.2.29): |
There was a problem hiding this comment.
Just a small rewording suggestion (the current wording is fine too, so no objections if you prefer it):
Suggested change
| If the hotfix branch is ready, you needed to create an annotated tag pointing to the hotfix branch head (example below for releasing version 1.2.29): | |
| If the hotfix branch is ready to be published, you needed to create an annotated tag pointing to the head of the hotfix branch. Below is an example for releasing version 1.2.29: |
waldyrious
reviewed
Feb 17, 2022
| If the hotfix branch is ready, you needed to create an annotated tag pointing to the hotfix branch head (example below for releasing version 1.2.29): | ||
|
|
||
| ```bash | ||
| # Ensure the tag is made on the udpated branch |
There was a problem hiding this comment.
Suggested change
| # Ensure the tag is made on the udpated branch | |
| # Ensure the branch is up-to-date before applying the tag |
waldyrious
reviewed
Feb 17, 2022
| git fetch -a | ||
| git checkout origin/hf-1.2.X | ||
| git tag -a 1.2.29 | ||
| # Your EDITOR will open. Write a good message and save as it is used on Github as a release message |
There was a problem hiding this comment.
Suggested change
| # Your EDITOR will open. Write a good message and save as it is used on Github as a release message | |
| # The command above will launch your default CLI text editor. | |
| # Write an informative message and save the contents, which will be used on GitHub as a release message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from https://github.com/feedzai/feedzai-openml-java/