Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods with "_safe" suffix are not supposed to raise exceptions #1408

Open
fedora-copr-github-bot opened this issue Nov 17, 2022 · 2 comments
Open

Methods with "_safe" suffix are not supposed to raise exceptions #1408

fedora-copr-github-bot opened this issue Nov 17, 2022 · 2 comments
Labels
doc

Comments

@fedora-copr-github-bot
Copy link
Collaborator

fedora-copr-github-bot commented Nov 17, 2022 •
edited
Loading

Original issue: https://pagure.io/copr/copr/issue/1408
Opened: 2020-06-14 14:17:33
Opened by: frostyx

Instead, they should return None if e.g. the object couldn't be found.
@fedora-copr-github-bot fedora-copr-github-bot added RFE Enhancement, feature requests code-cleanup easyfix labels Nov 22, 2022
@praiskup praiskup added doc and removed RFE Enhancement, feature requests easyfix code-cleanup labels Feb 14, 2023
@praiskup
Copy link
Member

Triage time: We should first have some "coding guidelines" that would give us conventions. And then this is probably not an easy task but some incremental effort to fix all the _safe methods.

@FrostyX
Copy link
Member

FrostyX commented Feb 15, 2023

We should first have some "coding guidelines" that would give us conventions.

I suggest defining them here
https://github.com/fedora-copr/copr/blob/main/CONTRIBUTE.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc
Projects
CPT Kanban
Status: Someday in future
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FrostyX @praiskup @fedora-copr-github-bot