Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let us specify custom mock config file (or snippet) #1336

Open
fedora-copr-github-bot opened this issue Nov 17, 2022 · 1 comment
Open

Let us specify custom mock config file (or snippet) #1336

fedora-copr-github-bot opened this issue Nov 17, 2022 · 1 comment
Labels
RFE Enhancement, feature requests

Comments

@fedora-copr-github-bot
Copy link
Collaborator

fedora-copr-github-bot commented Nov 17, 2022

Original issue: https://pagure.io/copr/copr/issue/1336
Opened: 2020-04-09 06:15:37
Opened by: praiskup

Screenshot_20200409_075307.png

I for some time miss the command copr edit-chroot, and I didn't have
time to implement it properly. And now, when thinking about #1334, I came
to an idea...

What if we removed all the options there on the web page, and only added
one textbox area instead which would provide "additional mock
configuration"? Copr would just concatenate the default config with the
one provided there. The mock configuration is order independent nowadays,
so it shouldn't make any practical difference.

That would give much much more powerful tool to any users as they could
experiment with any feature mock provides without forcing us to implement
additional knobs.

And it would simplify our life because there would be basically one field
in the form and -- WRT /bin/copr and API -- the command wouldn't have to
have any options (only copr edit-chroot CHROOTNAME FILENAME).

The negative of this proposal is that we would loose the form with all the
special-cased options. If this was the problem for anyone, we could
either

  • keep both variants (something like expert/normal mode)
  • keep the form JS only, and let it pre-fill the mock config snippet

Ideas?


praiskup commented at 2020-12-14 15:37:13:

See buzilla report that would use this:
https://bugzilla.redhat.com/show_bug.cgi?id=1758467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Enhancement, feature requests
Projects
Status: In 2 years
Development

No branches or pull requests

2 participants