Code style, fix typos, tweak tests

fedeisas · fedeisas · commit 3d7cf7edaf99 · 2020-04-04T22:30:08.000-03:00
diff --git a/src/CssInlinerPlugin.php b/src/CssInlinerPlugin.php
@@ -103,7 +103,7 @@ public function loadCssFilesFromLinks($message)
         }
 
         $link_tags = $dom->getElementsByTagName('link');
-        for ($i = $link_tags->length; --$i >= 0; ) {
+        for ($i = $link_tags->length; --$i >= 0;) {
             $link = $link_tags->item($i);
             if ($link->getAttribute('rel') === 'stylesheet') {
                 $link->parentNode->removeChild($link);
diff --git a/tests/CssInlinerPluginTest.php b/tests/CssInlinerPluginTest.php
@@ -60,7 +60,7 @@ public function itShouldConvertHtmlBody()
 
         $mailer->send($message);
 
-        $this->assertXmlStringEqualsXmlString(
+        $this->assertEquals(
             $this->stubs['converted-html'],
             $this->normalize($message->getBody())
         );
@@ -106,10 +106,7 @@ public function itShouldConvertHtmlBodyAndTextParts()
 
         $children = $message->getChildren();
 
-        $this->assertXmlStringEqualsXmlString(
-            $this->stubs['converted-html'],
-            $this->normalize($message->getBody())
-        );
+        $this->assertEquals($this->stubs['converted-html'], $this->normalize($message->getBody()));
         $this->assertEquals($this->stubs['plain-text'], $children[0]->getBody());
     }
 
@@ -150,10 +147,7 @@ public function itShouldConvertHtmlBodyAsAPart()
 
         $children = $message->getChildren();
 
-        $this->assertXmlStringEqualsXmlString(
-            $this->stubs['converted-html'],
-            $this->normalize($children[0]->getBody())
-        );
+        $this->assertEquals($this->stubs['converted-html'], $this->normalize($children[0]->getBody()));
     }
 
     /** @test **/
@@ -256,7 +250,7 @@ protected function normalize(string $html): string
             '/(?:<head>)(\s)+(?:<\/head>)/s', // libxml handles this different across platforms
         ];
 
-        $replace = [,
+        $replace = [
             '<head></head>',
         ];
 
diff --git a/tests/stubs/converted-html.stub b/tests/stubs/converted-html.stub
@@ -9,9 +9,18 @@
             div.block ul li.small {
                 margin: 10px;
             }
+            .picture-feed {
+                width: 50%;
+            }
+            @media (max-width: 768px) {
+                .picture-feed {
+                    width: 100%;
+                }
+            }
         </style>
     </head>
     <body>
+        <div><img class="picture-feed" src="foo.jpg" style="width: 50%;"></div>
         <div class="block" style="width: 100px; height: 20px;">
             text
 
diff --git a/tests/stubs/original-html.stub b/tests/stubs/original-html.stub
@@ -9,9 +9,18 @@
             div.block ul li.small {
                 margin: 10px;
             }
+            .picture-feed {
+                width: 50%;
+            }
+            @media (max-width: 768px) {
+                .picture-feed {
+                    width: 100%;
+                }
+            }
         </style>
     </head>
     <body>
+        <div><img class="picture-feed" src="foo.jpg"></div>
         <div class="block">
             text
 

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function loadCssFilesFromLinks($message)`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`$link_tags = $dom->getElementsByTagName('link');`
`106`		`- for ($i = $link_tags->length; --$i >= 0; ) {`
	`106`	`+ for ($i = $link_tags->length; --$i >= 0;) {`
`107`	`107`	`$link = $link_tags->item($i);`
`108`	`108`	`if ($link->getAttribute('rel') === 'stylesheet') {`
`109`	`109`	`$link->parentNode->removeChild($link);`