Skip to content

Commit 554d96b

Browse files
authored
Refactor update logger message when datafile fetching error (#74)
* refactor: update error message and its details when datafile couldn't be fetched * Fix swift format issue
1 parent 8b5556e commit 554d96b

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Sources/FeaturevisorSDK/Instance.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ public class FeaturevisorInstance {
261261
self?.startRefreshing()
262262
}
263263
case .failure(let error):
264-
self?.logger.error("Failed to fetch datafile: \(error)")
264+
self?.logger.error("failed to fetch datafile", ["error": error])
265265
}
266266
}
267267
}

Tests/FeaturevisorSDKTests/InstanceTests.swift

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1149,6 +1149,7 @@ class FeaturevisorInstanceTests: XCTestCase {
11491149
// GIVEN
11501150
let expectation = expectation(description: "datafile_error_response_expectation")
11511151
var wasDatafileContentFetchErrorThrown = false
1152+
var errorThrownDetails: String?
11521153
var options = InstanceOptions.default
11531154
options.datafileUrl = "https://featurevisor.datafilecontent.com"
11541155
options.handleDatafileFetch = { _ in
@@ -1159,8 +1160,9 @@ class FeaturevisorInstanceTests: XCTestCase {
11591160
return
11601161
}
11611162

1162-
if message.contains("Failed to fetch datafile") {
1163+
if message.contains("failed to fetch datafile") {
11631164
wasDatafileContentFetchErrorThrown = true
1165+
errorThrownDetails = details?.description
11641166
}
11651167

11661168
expectation.fulfill()
@@ -1179,6 +1181,10 @@ class FeaturevisorInstanceTests: XCTestCase {
11791181
// THEN
11801182
waitForExpectations(timeout: 1)
11811183
XCTAssertTrue(wasDatafileContentFetchErrorThrown)
1184+
XCTAssertEqual(
1185+
errorThrownDetails,
1186+
"[\"error\": FeaturevisorSDK.FeaturevisorError.unparseableJSON(data: nil, errorMessage: \"Error :(\")]"
1187+
)
11821188
}
11831189

11841190
func testShouldGetVariable() {

0 commit comments

Comments
 (0)