refactor: drop helper functions#10
Merged
fahad19 merged 5 commits intofeaturevisor:mainfrom Aug 22, 2025
Merged
Conversation
fahad19
reviewed
Aug 21, 2025
fahad19
reviewed
Aug 21, 2025
| $datafileContent = json_decode($datafileContent, true); | ||
|
|
||
| $f = createInstance([ | ||
| $f = Featurevisor::createInstance([ |
Member
|
will merge and release tomorrow (Friday) 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces global helper functions with static constructors on their respective classes, providing better developer experience through IDE autocompletion, improved code organization, and more efficient autoloading. It will give similar experience to Java SDK.
Changes
1. Replace
createInstancefunction with static constructorcreateInstance()global function to a static method on theFeaturevisorclassFeaturevisor::createInstance()2. Replace
createLoggerfunction with static constructorcreateLogger()global function to a static method on theLoggerclassLogger::create()functions.phpfile as all helpers have been moved to their classesMigration Impact
This is a backward-incompatible change that requires users to update their code to use the static constructors:
use function Featurevisor\createInstance;withuse Featurevisor\Featurevisor;createInstance([...])withFeaturevisor::createInstance([...])use function Featurevisor\createLogger;withuse Featurevisor\Logger;createLogger([...])withLogger::create([...])