Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization warnings in Angular 10 #2001

Open
arkenstan opened this issue Jun 28, 2020 · 3 comments · May be fixed by #3375 or #2665
Open

Optimization warnings in Angular 10 #2001

arkenstan opened this issue Jun 28, 2020 · 3 comments · May be fixed by #3375 or #2665

Comments

@arkenstan
Copy link

Steps to reproduce

On upgrading angular application to Angular 10.0.0 It gives warning for modules and packages that have dependency on commonjs or AMD for optimization bailouts

PSB Log for warnings

WARNING in src/app/core/services/feathers.service.ts depends on @feathersjs/socketio-client. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on @feathersjs/feathers. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on @feathersjs/authentication-client. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on socket.io-client. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on feathers-reactive. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

System configuration

Module versions
@feathersjs/authentication-client: "^4.5.4"
@feathersjs/feathers: "^4.5.3"
@feathersjs/socketio-client: "^4.5.4"
socket.io-client: "^2.3.0"

NodeJS version:
Node 12

Operating System:
Linux mint 19.3

@alejandroTapiaQ
Copy link

alejandroTapiaQ commented Aug 7, 2020

HI arkenstan well I resolve that warning adding this in angular.json file

`
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"allowedCommonJsDependencies": [
"socket.io-client",
"socket.io-parser",
"debug"
],

`
Also you can see #18025

@bertho-zero
Copy link
Collaborator

ESM builds should be added to correctly fix these warnings.

@axmad22
Copy link

axmad22 commented Oct 16, 2020

Had the same problem Warning: Entry point simplebar-angular contains deep imports
try adding in the angular.json in the "build"=> "options":

"allowedCommonJsDependencies": ["core-js"],

Also I kind of remember adding something in the tsconfig.json
that helped here is mine case check with default settings

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./public/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "downlevelIteration": true,
    "experimentalDecorators": true,
    "module": "esnext",
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es2015",
    "allowSyntheticDefaultImports": true,
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2018",
      "dom"
    ]
  }
}

@daffl daffl linked a pull request Dec 20, 2022 that will close this issue
@daffl daffl linked a pull request Dec 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants