-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run JobCoontroller as separate application #951
Conversation
/test test-end-to-end-batch-dataflow |
/test test-end-to-end-redis-cluster |
/test test-end-to-end |
/test test-end-to-end-redis-cluster |
/test test-end-to-end-redis-cluster |
/test test-end-to-end-auth |
/test test-end-to-end-auth |
job-controller/src/main/java/feast/jobcontroller/grpc/CoreServiceImpl.java
Outdated
Show resolved
Hide resolved
job-controller/src/main/java/feast/jobcontroller/service/JobControllerService.java
Outdated
Show resolved
Hide resolved
job-controller/src/test/java/feast/jobcontroller/service/JobControllerIT.java
Outdated
Show resolved
Hide resolved
/test test-end-to-end-batch |
1 similar comment
/test test-end-to-end-batch |
/lgtm |
/test test-end-to-end-batch |
3 similar comments
/test test-end-to-end-batch |
/test test-end-to-end-batch |
/test test-end-to-end-batch |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This is final PR in series of decoupling JobCoordinator (renamed to JobController) from Core.
Main features of PR:
job-controller
that should be run as standalone (spring) application (helm charts, docker compose, e2e tests updated)job-controller
usecore
intest
scope.CoreService.proto
). Since it could be deployed with several instances of JobController - routing between them is now client's responsibility. Also, client code (in python SDK) calling those methods were moved out of Feast Client. Now it's in contrib (seefeast.contrib.job_controller.client
in python SDK).Refactoring:
feast-common-test
moduleWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: