Enable linting and formatting for e2e tests #832
Merged
+364
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
requested review from
davidheryanto,
khorshuheng,
pyalex and
zhilingc
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
woop
commented
Jun 28, 2020
| return None, is_ok | ||
|
|
||
| wait_retry_backoff(retry_fn=try_get_features, | ||
| timeout_secs=90, | ||
| timeout_msg="Timed out trying to get online feature values") |
There was a problem hiding this comment.
This wait_retry_backoff is unreachable @mrzzy. Not sure if you have context on it?
There was a problem hiding this comment.
I will remove it for the time being. Please submit a new PR if it's actually being used.
|
/test test-end-to-end-batch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We currently have Python based formatting and linting for the Python SDK (code and tests), however our end to end test suite also uses Python but isn't covered by linting or formatting. This PR includes the
tests/e2efolder under the coverage ofmake format-pythonandmake lint-pythonDoes this PR introduce a user-facing change?: