Refactor runner configuration, add labels to dataflow options #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhilingc
requested review from
davidheryanto,
khorshuheng,
pradithya and
woop
as code owners
ches
reviewed
May 21, 2020
| import java.util.Map; | ||
|
|
||
| public abstract class RunnerConfig { | ||
| public String[] toArgs() throws IllegalAccessException { |
zhilingc
added
the
area/ingestion
|
/lgtm |
woop
approved these changes
Jun 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zhilingc is this going to be backported to 0.5? |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Jun 5, 2020
…dev#718) * Refactor runner configuration, add labels to dataflow options * Remove util method * Add javadocs for RunnerConfig class * Apply spotless
khorshuheng
pushed a commit
that referenced
this pull request
Jun 5, 2020
* Refactor runner configuration, add labels to dataflow options * Remove util method * Add javadocs for RunnerConfig class * Apply spotless
zhangchi1
pushed a commit
to Cimpress-MCP/feast
that referenced
this pull request
Jun 11, 2020
…dev#718) * Refactor runner configuration, add labels to dataflow options * Remove util method * Add javadocs for RunnerConfig class * Apply spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds option of setting labels for dataflow jobs, and cleans up the job configuration code a bit, also ties the runner configuration classes to the protos. Both runners extend the
RunnerConfigclass which support conversion of the config fields to beam args.