Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added uvicorn-worker dependency #4659

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

tmihalac
Copy link
Contributor

@tmihalac tmihalac commented Oct 21, 2024

What this PR does / why we need it:

Removes the deprecation warning: for uvicorn.workers.
The uvicorn.workers module is deprecated, they refer using uvicorn-worker package instead.

Which issue(s) this PR fixes:

Fixes #4638

@tmihalac tmihalac changed the title Added uvicorn-worker dependency bug: Removes the deprecation warning for uvicorn.workers Oct 21, 2024
@franciscojavierarceo franciscojavierarceo changed the title bug: Removes the deprecation warning for uvicorn.workers chore: Added uvicorn-worker dependency Oct 21, 2024
@franciscojavierarceo
Copy link
Member

@dmartinol @redhatHameed it appears that one of the tests here is flaky:

FAILED sdk/python/tests/integration/online_store/test_remote_online_store.py::test_remote_online_store_read[\nauth:\n type: no_auth\n] - TimeoutError: Unable to start the feast server in 60 seconds for remote online store type, port=42745
FAILED sdk/python/tests/integration/online_store/test_remote_online_store.py::test_remote_online_store_read[\nauth:\n type: oidc\n client_id: feast-integration-client\n client_secret: feast-integration-client-secret\n username: reader_writer\n password: password\n auth_discovery_url: KEYCLOAK_URL_PLACE_HOLDER/realms/master/.well-known/openid-configuration\n] - TimeoutError: Unable to start the feast server in 60 seconds for remote online store type, port=46341

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
@tmihalac
Copy link
Contributor Author

@dmartinol @redhatHameed it appears that one of the tests here is flaky:

FAILED sdk/python/tests/integration/online_store/test_remote_online_store.py::test_remote_online_store_read[\nauth:\n type: no_auth\n] - TimeoutError: Unable to start the feast server in 60 seconds for remote online store type, port=42745
FAILED sdk/python/tests/integration/online_store/test_remote_online_store.py::test_remote_online_store_read[\nauth:\n type: oidc\n client_id: feast-integration-client\n client_secret: feast-integration-client-secret\n username: reader_writer\n password: password\n auth_discovery_url: KEYCLOAK_URL_PLACE_HOLDER/realms/master/.well-known/openid-configuration\n] - TimeoutError: Unable to start the feast server in 60 seconds for remote online store type, port=46341

Not sure that is the only issue, updated the PR

@dmartinol
Copy link
Contributor

@dmartinol @redhatHameed it appears that one of the tests here is flaky:

Can this be related to #4658?

Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@franciscojavierarceo franciscojavierarceo merged commit 9ca1452 into feast-dev:master Oct 22, 2024
21 checks passed
emgeee pushed a commit to emgeee/feast that referenced this pull request Oct 23, 2024
Added uvicorn-worker dependency

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
emgeee pushed a commit to emgeee/feast that referenced this pull request Oct 23, 2024
Added uvicorn-worker dependency

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uvicorn.workers module is deprecated warning on feast serve
3 participants