-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry options to BigQuery #431
Conversation
Add two fields to job properties and use them to set retry options in all BigQuery job waitFor calls, as per Google example.
Hi @Yanson. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @woop |
/ok-to-test |
/test test-end-to-end-batch |
1 similar comment
/test test-end-to-end-batch |
/test test-end-to-end-batch |
Hopefully this retest will pass. I will update the user-facing notes on Monday as it's worth mentioning. |
/lgtm I think the whole serving jobs configuration needs a bit of a refactor but I think that's a PR for another day. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto, Yanson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Failure to specify the configs described may result in the following error message in logs: Client:
Server:
|
* Add retry options to BigQuery Add two fields to job properties and use them to set retry options in all BigQuery job waitFor calls, as per Google example. * Change timeout defaults and add config to e2e test to fix failure.
What this PR does / why we need it:
Add two fields to job properties and use them to set retry options in all BigQuery job waitFor calls, as per Google example.
This fixes an issue where job metadata is sometimes used on an object that does not have it set, since the job was not reassigned to the completed job reference that waitFor returns.
Additionally handles errors with best practice and allows some retry options to be configured by the user.
Does this PR introduce a user-facing change?: