Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updating contributing guide and also fixing some issues around M1 dev #3621

Merged
merged 1 commit into from
May 10, 2023

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented May 9, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia adchia merged commit 04afc71 into feast-dev:master May 10, 2023
@adchia adchia deleted the fixDev branch May 10, 2023 17:25
adchia added a commit that referenced this pull request May 10, 2023
…M1 dev (#3621)

Updating contributing guide and also fixing some issues around M1 dev

Signed-off-by: Danny C <d.chiao@gmail.com>
zerafachris pushed a commit to zerafachris/feast that referenced this pull request Mar 5, 2024
…M1 dev (feast-dev#3621)

Updating contributing guide and also fixing some issues around M1 dev

Signed-off-by: Danny C <d.chiao@gmail.com>
Signed-off-by: zerafachris PERSONAL <zerafachris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants