Skip to content

Commit

Permalink
fix: Feast create empty online table when FeatureView attribute onlin…
Browse files Browse the repository at this point in the history
…e=False (#4666)

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
  • Loading branch information
tmihalac authored Oct 28, 2024
1 parent 86573d2 commit 237c453
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion sdk/python/feast/infra/passthrough_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,16 @@ def update_infra(
):
# Call update only if there is an online store
if self.online_store:
tables_to_keep_online = [
fv
for fv in tables_to_keep
if not hasattr(fv, "online") or (hasattr(fv, "online") and fv.online)
]

self.online_store.update(
config=self.repo_config,
tables_to_delete=tables_to_delete,
tables_to_keep=tables_to_keep,
tables_to_keep=tables_to_keep_online,
entities_to_keep=entities_to_keep,
entities_to_delete=entities_to_delete,
partial=partial,
Expand Down

0 comments on commit 237c453

Please sign in to comment.