Skip to content
This repository was archived by the owner on Sep 28, 2023. It is now read-only.

Corrected crash from F8MapView #1

Merged
merged 2 commits into from
Apr 16, 2016
Merged

Corrected crash from F8MapView #1

merged 2 commits into from
Apr 16, 2016

Conversation

jpros
Copy link
Contributor

@jpros jpros commented Apr 13, 2016

When the user accesses for the first time without connection, and opens the Map tab, the app crashes and never recover (even with internet).

…time without connection, and opens the Map tab, the app crashes and never recover (even with internet).
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@jpros
Copy link
Contributor Author

jpros commented Apr 13, 2016

@facebook-github-bot done!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed The PR author has signed the Facebook CLA. label Apr 13, 2016
@qpowell
Copy link

qpowell commented Apr 13, 2016

@jpros Thanks. I had to uninstall the app, relaunch it, and avoid clicking on maps in order to check out the rest of it :)

@frantic
Copy link
Contributor

frantic commented Apr 14, 2016

@jpros are you running the Parse Server locally?

@jpros
Copy link
Contributor Author

jpros commented Apr 15, 2016

@frantic Yes.

@frantic
Copy link
Contributor

frantic commented Apr 15, 2016

@jpros – how about adb reverse tcp:8080 tcp:8080?

@jpros
Copy link
Contributor Author

jpros commented Apr 15, 2016

@frantic I'm not understanding your point. There was a bug in the app, and I fixed it.
The problem was if the user was without connection, the app would crash on the map screen. It's not a problem with debugging or testing the app locally. This issue happens on both platforms in your released app.

@frantic
Copy link
Contributor

frantic commented Apr 15, 2016

@jpros thanks for you efforts. For me to merge this in, please address the inline comments.

title={map1.name}
renderEmptyList={() => <MapView map={map1} />}
title={map1Name}
renderEmptyList={() => readerEmptyListMap1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<MapView /> gracefully handles the case when map is empty, we don't need readerEmptyListMap1/2.

@jpros
Copy link
Contributor Author

jpros commented Apr 16, 2016

@frantic Nice, I'll update this.
Unfortunately I'm new to React Native, this is my first experience with it. As I don't know the F8 project by its entirely, I wasn't sure if the map name was going to be different than "Overview"/"Developer Garage" or not. Also, I didn't know that MapView could handle the case with empty map.

Thanks for your help, and I'm sure there will be a lot of learning about React Native on the next few weeks.

@frantic frantic merged commit 6addb95 into fbsamples:master Apr 16, 2016
@frantic
Copy link
Contributor

frantic commented Apr 16, 2016

Thanks!

frantic pushed a commit that referenced this pull request Apr 26, 2016
When the user accesses for the first time without connection, and opens the Map tab, the app crashes and never recover (even with internet).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed The PR author has signed the Facebook CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants