Corrected crash from F8MapView #1
Conversation
…time without connection, and opens the Map tab, the app crashes and never recover (even with internet).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
@facebook-github-bot done! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
@jpros Thanks. I had to uninstall the app, relaunch it, and avoid clicking on maps in order to check out the rest of it :) |
|
@jpros are you running the Parse Server locally? |
|
@frantic Yes. |
|
@jpros – how about |
|
@frantic I'm not understanding your point. There was a bug in the app, and I fixed it. |
|
@jpros thanks for you efforts. For me to merge this in, please address the inline comments. |
| title={map1.name} | ||
| renderEmptyList={() => <MapView map={map1} />} | ||
| title={map1Name} | ||
| renderEmptyList={() => readerEmptyListMap1} |
There was a problem hiding this comment.
<MapView /> gracefully handles the case when map is empty, we don't need readerEmptyListMap1/2.
|
@frantic Nice, I'll update this. Thanks for your help, and I'm sure there will be a lot of learning about React Native on the next few weeks. |
…moving unnecessary code.
|
Thanks! |
When the user accesses for the first time without connection, and opens the Map tab, the app crashes and never recover (even with internet).
When the user accesses for the first time without connection, and opens the Map tab, the app crashes and never recover (even with internet).