[GEN][ZH] Enable Chat for Observers (TheSuperHackers#864)

Bart Roossien | SkyAero · web-flow · commit ef8b23f26cd8 · 2025-07-20T10:14:44.000+02:00
diff --git a/Generals/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp b/Generals/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp
@@ -2914,7 +2914,8 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
 			if (TheGameLogic->isInMultiplayerGame() && !TheGameLogic->isInReplayGame())
 			{
 				Player *localPlayer = ThePlayerList->getLocalPlayer();
-				if (localPlayer && localPlayer->isPlayerActive() || !TheGlobalData->m_netMinPlayers)
+				// TheSuperHackers @tweak skyaero 19/07/2025 Observers can now chat
+				if (localPlayer || !TheGlobalData->m_netMinPlayers)
 				{
 					ToggleInGameChat();
 					SetInGameChatType( INGAME_CHAT_EVERYONE );
diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp
@@ -3061,7 +3061,8 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage
 			if (TheGameLogic->isInMultiplayerGame() && !TheGameLogic->isInReplayGame())
 			{
 				Player *localPlayer = ThePlayerList->getLocalPlayer();
-				if (localPlayer && localPlayer->isPlayerActive() || !TheGlobalData->m_netMinPlayers)
+				// TheSuperHackers @tweak skyaero 19/07/2025 Observers can now chat
+				if (localPlayer || !TheGlobalData->m_netMinPlayers)
 				{
 					ToggleInGameChat();
 					SetInGameChatType( INGAME_CHAT_EVERYONE );

Original file line number	Diff line number	Diff line change
`@@ -2914,7 +2914,8 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage`
`2914`	`2914`	`if (TheGameLogic->isInMultiplayerGame() && !TheGameLogic->isInReplayGame())`
`2915`	`2915`	`{`
`2916`	`2916`	`Player *localPlayer = ThePlayerList->getLocalPlayer();`
`2917`		`- if (localPlayer && localPlayer->isPlayerActive() \|\| !TheGlobalData->m_netMinPlayers)`
	`2917`	`+ // TheSuperHackers @tweak skyaero 19/07/2025 Observers can now chat`
	`2918`	`+ if (localPlayer \|\| !TheGlobalData->m_netMinPlayers)`
`2918`	`2919`	`{`
`2919`	`2920`	`ToggleInGameChat();`
`2920`	`2921`	`SetInGameChatType( INGAME_CHAT_EVERYONE );`
Original file line number	Diff line number	Diff line change
`@@ -3061,7 +3061,8 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage`
`3061`	`3061`	`if (TheGameLogic->isInMultiplayerGame() && !TheGameLogic->isInReplayGame())`
`3062`	`3062`	`{`
`3063`	`3063`	`Player *localPlayer = ThePlayerList->getLocalPlayer();`
`3064`		`- if (localPlayer && localPlayer->isPlayerActive() \|\| !TheGlobalData->m_netMinPlayers)`
	`3064`	`+ // TheSuperHackers @tweak skyaero 19/07/2025 Observers can now chat`
	`3065`	`+ if (localPlayer \|\| !TheGlobalData->m_netMinPlayers)`
`3065`	`3066`	`{`
`3066`	`3067`	`ToggleInGameChat();`
`3067`	`3068`	`SetInGameChatType( INGAME_CHAT_EVERYONE );`