Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing watchface includes #6

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

davidakerr
Copy link
Contributor

Without these I could not compile the project.

Copy link
Owner

@fbiego fbiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange because the function declarations are already present in the respective watchface header files

@davidakerr
Copy link
Contributor Author

davidakerr commented Jun 20, 2024

This is strange because the function declarations are already present in the respective watchface header files

I think it was due to differing face enable pragmas across SDL2 and ESP32.

Would this solution be better ?

@davidakerr davidakerr requested a review from fbiego June 20, 2024 23:40
@davidakerr davidakerr changed the title Add missing function declarations Conditionally include function declarations Jun 21, 2024
fbiego

This comment was marked as outdated.

@fbiego fbiego marked this pull request as draft June 21, 2024 18:03
Copy link
Owner

@fbiego fbiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have identified the issue, looks like the new watchface header files were not included in ui.c

The corresponding headers files need to be included just like the other watchfaces

https://github.com/davidakerr/esp32-c3-mini/blob/4ea9db98d9b4246dea4b4bdf311465d7cc53d047/src/ui/ui.c#L9C1-L20C45

@fbiego fbiego added the bug Something isn't working label Jun 21, 2024
@davidakerr davidakerr marked this pull request as ready for review June 21, 2024 21:01
@davidakerr davidakerr requested a review from fbiego June 21, 2024 21:01
Copy link
Owner

@fbiego fbiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for the update

@fbiego fbiego merged commit 81cbb22 into fbiego:main Jun 21, 2024
@fbiego fbiego changed the title Conditionally include function declarations Missing watchface includes Jun 21, 2024
@fbiego fbiego added fixed The issue has been fixed and removed bug Something isn't working labels Jun 21, 2024
@davidakerr
Copy link
Contributor Author

awesome, thanks for the update

Thanks the help and for the great repository.

@davidakerr davidakerr deleted the update-ui-defs branch June 21, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed The issue has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants