Skip to content

Commit 903fb43

Browse files
authored
fix(parser): Implied close indices would be misreported (#933)
See posthtml/posthtml-parser#80 (comment)
1 parent 78ef1b7 commit 903fb43

File tree

7 files changed

+116
-116
lines changed

7 files changed

+116
-116
lines changed

src/Parser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ export class Parser {
330330
let count = this.stack.length - pos;
331331
while (count--) {
332332
// We know the stack has sufficient elements.
333-
this.cbs.onclosetag(this.stack.pop()!, pos !== 0);
333+
this.cbs.onclosetag(this.stack.pop()!, count !== 0);
334334
}
335335
} else this.stack.length = pos;
336336
} else if (!this.options.xmlMode && name === "p") {

src/__fixtures__/Events/02-template.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"event": "closetag",
4949
"startIndex": 49,
5050
"endIndex": 57,
51-
"data": ["script", true]
51+
"data": ["script", false]
5252
},
5353
{
5454
"event": "closetag",

src/__fixtures__/Events/08-implicit-close-tags.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
"event": "closetag",
157157
"startIndex": 83,
158158
"endIndex": 87,
159-
"data": ["h3", true]
159+
"data": ["h3", false]
160160
},
161161
{
162162
"event": "closetag",
@@ -216,7 +216,7 @@
216216
"event": "closetag",
217217
"startIndex": 104,
218218
"endIndex": 109,
219-
"data": ["div", true]
219+
"data": ["div", false]
220220
},
221221
{
222222
"event": "closetag",
@@ -258,7 +258,7 @@
258258
"event": "closetag",
259259
"startIndex": 123,
260260
"endIndex": 128,
261-
"data": ["div", true]
261+
"data": ["div", false]
262262
},
263263
{
264264
"event": "closetag",
@@ -276,13 +276,13 @@
276276
"event": "closetag",
277277
"startIndex": 129,
278278
"endIndex": 136,
279-
"data": ["table", true]
279+
"data": ["table", false]
280280
},
281281
{
282282
"event": "closetag",
283283
"startIndex": 137,
284284
"endIndex": 142,
285-
"data": ["div", true]
285+
"data": ["div", false]
286286
},
287287
{
288288
"event": "closetag",
@@ -336,19 +336,19 @@
336336
"event": "closetag",
337337
"startIndex": 165,
338338
"endIndex": 169,
339-
"data": ["h3", true]
339+
"data": ["h3", false]
340340
},
341341
{
342342
"event": "closetag",
343343
"startIndex": 170,
344344
"endIndex": 175,
345-
"data": ["div", true]
345+
"data": ["div", false]
346346
},
347347
{
348348
"event": "closetag",
349349
"startIndex": 176,
350350
"endIndex": 180,
351-
"data": ["li", true]
351+
"data": ["li", false]
352352
},
353353
{
354354
"event": "closetag",
@@ -480,7 +480,7 @@
480480
"event": "closetag",
481481
"startIndex": 231,
482482
"endIndex": 235,
483-
"data": ["li", false]
483+
"data": ["li", true]
484484
},
485485
{
486486
"event": "closetag",

src/__fixtures__/Events/11-script_in_script.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"event": "closetag",
3737
"startIndex": 44,
3838
"endIndex": 52,
39-
"data": ["script", true]
39+
"data": ["script", false]
4040
},
4141
{
4242
"event": "closetag",

src/__fixtures__/Events/24-special_special.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"event": "closetag",
5555
"startIndex": 42,
5656
"endIndex": 45,
57-
"data": ["b", true]
57+
"data": ["b", false]
5858
},
5959
{
6060
"event": "closetag",
@@ -90,7 +90,7 @@
9090
"event": "closetag",
9191
"startIndex": 64,
9292
"endIndex": 67,
93-
"data": ["b", true]
93+
"data": ["b", false]
9494
},
9595
{
9696
"event": "closetag",

src/__fixtures__/Events/44-indices.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"event": "closetag",
5555
"startIndex": 39,
5656
"endIndex": 46,
57-
"data": ["title", true]
57+
"data": ["title", false]
5858
},
5959
{
6060
"event": "text",
@@ -108,13 +108,13 @@
108108
"event": "closetag",
109109
"startIndex": 81,
110110
"endIndex": 84,
111-
"data": ["p", true]
111+
"data": ["p", false]
112112
},
113113
{
114114
"event": "closetag",
115115
"startIndex": 85,
116116
"endIndex": 91,
117-
"data": ["body", true]
117+
"data": ["body", false]
118118
},
119119
{
120120
"event": "text",

0 commit comments

Comments
 (0)