New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert cancel getmany and add extra seek #256

Merged

patkivikram merged 3 commits into faust-streaming:master from ekerstens:reseek_during_inactive_flow

Jan 11, 2022

Contributor

ekerstens commented Jan 11, 2022 •

edited

Loading

Description

Revert Stop fetching when flow stops #253 because task cancellation did not propagate to the service thread, resulting in orphaned fetchers continuing to fetch without returning to anything.
~~Add extra check to _wait_next_records to make sure flow is actually resumed before continuing~~
Reseek to committed offsets if getmany completes while flow is not active.

Eric Kerstens added 3 commits

January 11, 2022 10:28


          Revert cancel getmany and add extra seek

2cb0fb7


          Revert test

fb21ff7


          Modifications for tests

66edcb3

patkivikram approved these changes

View reviewed changes

patkivikram merged commit a7256eb into faust-streaming:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet