-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make optional types explicit #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also fix optional types for worker
@patkivikram can someone approve to run workflows in this PR? |
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 94.25% 94.23% -0.02%
==========================================
Files 100 100
Lines 10826 10829 +3
Branches 1479 1479
==========================================
+ Hits 10204 10205 +1
- Misses 551 553 +2
Partials 71 71
Continue to review full report at Codecov.
|
patkivikram
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make optional types explicit. A past version of PEP-484 allowed type checkers to assume an optional type when the default value is None, as in this code:
This would have been treated as equivalent to:
This is no longer the recommended behavior. Type checkers should move towards requiring the optional type to be made explicit. For more info see: https://www.python.org/dev/peps/pep-0484/#id29