Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newer version of open tracing #50

Closed
tarbaig opened this issue Dec 3, 2020 · 1 comment · Fixed by #52
Closed

newer version of open tracing #50

tarbaig opened this issue Dec 3, 2020 · 1 comment · Fixed by #52

Comments

@tarbaig
Copy link
Contributor

tarbaig commented Dec 3, 2020

Checklist

  • [ X ] I have included information about relevant versions
  • [ X ] I have verified that the issue persists when using the master branch of Faust.

Steps to reproduce

Install faust together with a current version of jaeger-client (which requires opentracing>=2.1)

Expected behavior

No version conflict should arise

Actual behavior

faust claims to be unable to work with opentracing>=2.0.0

Full traceback

ERROR: jaeger-client 4.3.0 has requirement opentracing<3.0,>=2.1, but you'll have opentracing 1.3.0 which is incompatible.

Versions

  • Python version
    3.7
  • Faust version
    faust-streaming-0.3.0
  • Operating system
    linux

According to this issue in the original project just bumping the version number here should be enough to enable opentracing>2.0.0.

The reason it was not upgraded in the original project was a possible incompatibility in robinhoods closed source internal tracing framework.

I tried it locally and all tests work.

@patkivikram
Copy link
Collaborator

Sounds good - we use it for datadog with opentracing>=2.0.0. Can you create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants