Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling OverlayInteraction does not prevent click events from being blocked #100

Open
Wisdawg opened this issue May 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Wisdawg
Copy link

Wisdawg commented May 2, 2024

The bug
Setting the options value of preventOverlayInteraction to false allows interaction but doesn't allow the actual click events to occur. This seems to be a bug.

To Reproduce
eg.
If you instantiate a <VOnboardingWrapper :options="options"> with the options below when the Tour popover appears, other buttons on the screen will be hoverable and clickable, but their actual click events won't fire. ie. Hyperlinks will not route you to a new page.

    const options = {
      overlay: {
        enabled: false,
        preventOverlayInteraction: true,
      },
      hideButtons: {
        previous: false,
        next: true,
        exit: false,
      },
    }

Screenshots
It looks like the FocusTrap library is being called on to prevent event propagation:
https://github.com/fatihsolhan/v-onboarding/blob/main/src/components/VOnboardingStep.vue#L96
Screenshot 2024-05-01 at 4 41 41 PM

Expected behavior
When preventOverlayInteraction is made false interaction AND events become unblocked. Alternatively, if you want to keep interaction blocking separate from event blocking you could introduce a new value in options, perhaps called preventOverlayClickEvents? And if this feature already exists please let me know how to use it.

Desktop (please complete the following information):

  • OS: macOS Sonoma 14.2
  • Browser: Chrome
@Wisdawg Wisdawg added the bug Something isn't working label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant