coderabbit

ComputelessComputer · ComputelessComputer · commit 87d2b64ed355 · 2025-10-24T16:57:14.000+09:00
diff --git a/apps/desktop/src/components/main/body/calendars/calendar-day.tsx b/apps/desktop/src/components/main/body/calendars/calendar-day.tsx
@@ -17,7 +17,6 @@ export function TabContentCalendarDay({
   day: string;
   isCurrentMonth: boolean;
   isFirstColumn: boolean;
-  isLastColumn: boolean;
   isLastRow: boolean;
   selectedCalendars: Set<string>;
 }) {
diff --git a/apps/desktop/src/components/main/body/calendars/day-events.tsx b/apps/desktop/src/components/main/body/calendars/day-events.tsx
@@ -13,6 +13,8 @@ export function TabContentCalendarDayEvents({ eventId }: { eventId: string }) {
   const [open, setOpen] = useState(false);
   const { openNew } = useTabs();
 
+  const title = event?.title || "Untitled Event";
+
   const sessionIds = persisted.UI.useSliceRowIds(
     persisted.INDEXES.sessionsByEvent,
     eventId,
@@ -32,7 +34,7 @@ export function TabContentCalendarDayEvents({ eventId }: { eventId: string }) {
   };
 
   const formatEventTime = () => {
-    if (!event.started_at || !event.ended_at) {
+    if (!event || !event.started_at || !event.ended_at) {
       return "";
     }
     const start = new Date(event.started_at);
@@ -57,13 +59,13 @@ export function TabContentCalendarDayEvents({ eventId }: { eventId: string }) {
             ["w-full justify-start px-1 text-neutral-600 h-6", open && "bg-neutral-100 hover:bg-neutral-100"],
           )}
         >
-          <Calendar className="text-pink-600" />
-          <p className="truncate">{event.title}</p>
+          <Calendar size={12} className="text-pink-600" />
+          <p className="truncate">{title}</p>
         </Button>
       </PopoverTrigger>
       <PopoverContent className="w-72 p-4 bg-white border-neutral-200 m-2 shadow-lg outline-none focus:outline-none focus:ring-0">
         <div className="font-semibold text-lg text-neutral-800 mb-2">
-          {event.title || "Untitled Event"}
+          {title}
         </div>
 
         <p className="text-sm text-neutral-600 mb-4">
diff --git a/apps/desktop/src/components/main/body/calendars/day-sessions.tsx b/apps/desktop/src/components/main/body/calendars/day-sessions.tsx
@@ -9,16 +9,17 @@ export function TabContentCalendarDaySessions({ sessionId }: { sessionId: string
   const session = persisted.UI.useRow("sessions", sessionId, persisted.STORE_ID);
   const { openNew } = useTabs();
 
-  const event = persisted.UI.useRow("events", session.event_id || "dummy", persisted.STORE_ID);
+  const eventId = session?.event_id ?? "";
+  const event = persisted.UI.useRow("events", eventId, persisted.STORE_ID);
 
   const handleClick = () => {
     openNew({ type: "sessions", id: sessionId, state: { editor: "raw" } });
   };
 
   return (
     <Button variant="ghost" className="w-full justify-start px-1 text-neutral-600 h-6" onClick={handleClick}>
-      <StickyNote className="text-blue-600" />
-      <p className="truncate">{event && session.event_id ? event.title : session.title || "Untitled"}</p>
+      <StickyNote size={12} className="text-blue-600" />
+      <p className="truncate">{event && eventId ? event.title : session?.title || "Untitled"}</p>
     </Button>
   );
 }
diff --git a/apps/desktop/src/components/main/body/calendars/tab-content-calendar.tsx b/apps/desktop/src/components/main/body/calendars/tab-content-calendar.tsx
@@ -25,7 +25,10 @@ export function TabContentCalendar({ tab }: { tab: Tab }) {
   if (tab.type !== "calendars") {
     return null;
   }
+  return <TabContentCalendarInner tab={tab} />;
+}
 
+function TabContentCalendarInner({ tab }: { tab: Extract<Tab, { type: "calendars" }> }) {
   const [sidebarOpen, setSidebarOpen] = useState(false);
 
   const { openCurrent } = useTabs();
@@ -159,7 +162,6 @@ export function TabContentCalendar({ tab }: { tab: Tab }) {
                     day={day}
                     isCurrentMonth={isSameMonth(new Date(day), tab.month)}
                     isFirstColumn={dayIndex === 0}
-                    isLastColumn={dayIndex === 6}
                     isLastRow={weekIndex === 5}
                     selectedCalendars={selectedCalendars}
                   />
diff --git a/apps/desktop/src/components/main/body/contacts/organization-details.tsx b/apps/desktop/src/components/main/body/contacts/organization-details.tsx
@@ -42,7 +42,7 @@ export function OrganizationDetailsColumn({
                     <div className="flex-1">
                       <EditableOrganizationNameField organizationId={selectedOrganizationId} />
                       <p className="text-sm text-neutral-500 mt-1">
-                        {peopleInOrg.length} {peopleInOrg.length === 1 ? "person" : "people"}
+                        {peopleInOrg?.length ?? 0} {(peopleInOrg?.length ?? 0) === 1 ? "person" : "people"}
                       </p>
                     </div>
                   </div>
@@ -54,7 +54,7 @@ export function OrganizationDetailsColumn({
               <div className="p-6">
                 <h3 className="text-sm font-medium text-neutral-600 mb-4">People</h3>
                 <div className="overflow-y-auto" style={{ maxHeight: "55vh" }}>
-                  {peopleInOrg.length > 0
+                  {(peopleInOrg?.length ?? 0) > 0
                     ? (
                       <div className="grid grid-cols-3 gap-4">
                         {peopleInOrg.map((humanId: string) => {
@@ -90,7 +90,10 @@ export function OrganizationDetailsColumn({
                                     <Button
                                       variant="ghost"
                                       size="icon"
-                                      onClick={() => openUrl(`mailto:${human.email}`)}
+                                      onClick={(e) => {
+                                        e.stopPropagation();
+                                        openUrl(`mailto:${human.email}`);
+                                      }}
                                       title="Send email"
                                     >
                                       <Mail />
@@ -100,7 +103,14 @@ export function OrganizationDetailsColumn({
                                     <Button
                                       variant="ghost"
                                       size="icon"
-                                      onClick={() => openUrl(human.linkedin_username as string)}
+                                      onClick={(e) => {
+                                        e.stopPropagation();
+                                        const v = String(human.linkedin_username ?? "");
+                                        const href = /^https?:\/\//i.test(v)
+                                          ? v
+                                          : `https://www.linkedin.com/in/${v.replace(/^@/, "")}`;
+                                        void openUrl(href);
+                                      }}
                                       title="View LinkedIn profile"
                                     >
                                       <Icon icon="logos:linkedin-icon" />
diff --git a/apps/desktop/src/components/main/body/sessions/outer-header/metadata/date.tsx b/apps/desktop/src/components/main/body/sessions/outer-header/metadata/date.tsx
@@ -3,7 +3,11 @@ import { formatDate, isSameDay } from "@hypr/utils";
 import { useMeetingMetadata } from "./shared";
 
 export function MeetingDate({ sessionId }: { sessionId: string }) {
-  const meta = useMeetingMetadata(sessionId)!;
+  const meta = useMeetingMetadata(sessionId);
+
+  if (!meta?.started_at && !meta?.ended_at) {
+    return null;
+  }
 
   return (
     <p className="text-sm text-neutral-700">
diff --git a/apps/desktop/src/components/main/body/sessions/outer-header/metadata/description.tsx b/apps/desktop/src/components/main/body/sessions/outer-header/metadata/description.tsx
@@ -1,9 +1,9 @@
 import { useMeetingMetadata } from "./shared";
 
 export function MeetingDescription({ sessionId }: { sessionId: string }) {
-  const meta = useMeetingMetadata(sessionId)!;
+  const meta = useMeetingMetadata(sessionId);
 
-  if (!meta.description) {
+  if (!meta?.description) {
     return null;
   }
 
diff --git a/apps/desktop/src/components/main/body/sessions/outer-header/metadata/link.tsx b/apps/desktop/src/components/main/body/sessions/outer-header/metadata/link.tsx
@@ -13,13 +13,17 @@ import { useCallback } from "react";
 import { useMeetingMetadata } from "./shared";
 
 export function MeetingLink({ sessionId }: { sessionId: string }) {
-  const meta = useMeetingMetadata(sessionId)!;
+  const meta = useMeetingMetadata(sessionId);
 
   const handleCopyLink = useCallback(() => {
-    if (meta.meeting_link) {
+    if (meta?.meeting_link) {
       navigator.clipboard.writeText(meta.meeting_link);
     }
-  }, [meta.meeting_link]);
+  }, [meta?.meeting_link]);
+
+  if (!meta?.meeting_link) {
+    return null;
+  }
 
   return (
     <div className="flex items-center justify-between gap-2 -ml-2.5">
diff --git a/apps/desktop/src/components/main/body/sessions/outer-header/metadata/location.tsx b/apps/desktop/src/components/main/body/sessions/outer-header/metadata/location.tsx
@@ -3,9 +3,9 @@ import { MapPinIcon } from "lucide-react";
 import { useMeetingMetadata } from "./shared";
 
 export function MeetingLocation({ sessionId }: { sessionId: string }) {
-  const meta = useMeetingMetadata(sessionId)!;
+  const meta = useMeetingMetadata(sessionId);
 
-  if (!meta.location) {
+  if (!meta?.location) {
     return null;
   }
 
diff --git a/apps/desktop/src/components/main/body/sessions/outer-header/overflow.tsx b/apps/desktop/src/components/main/body/sessions/outer-header/overflow.tsx
@@ -1,4 +1,5 @@
 import { FileTextIcon, FolderIcon, Link2Icon, MicIcon, MicOffIcon, MoreHorizontalIcon, TrashIcon } from "lucide-react";
+import { useState } from "react";
 
 import { Button } from "@hypr/ui/components/ui/button";
 import {
@@ -15,16 +16,18 @@ import { useStartListening } from "../../../../../hooks/useStartListening";
 import { SearchableFolderSubmenuContent } from "./shared/folder";
 
 export function OverflowButton({ sessionId }: { sessionId: string }) {
+  const [open, setOpen] = useState(false);
+
   return (
-    <DropdownMenu>
+    <DropdownMenu open={open} onOpenChange={setOpen}>
       <DropdownMenuTrigger asChild>
         <Button size="icon" variant="ghost">
           <MoreHorizontalIcon size={16} />
         </Button>
       </DropdownMenuTrigger>
       <DropdownMenuContent align="end" className="w-56">
         <Copy />
-        <Folder sessionId={sessionId} />
+        <Folder sessionId={sessionId} setOpen={setOpen} />
         <ExportPDF />
         <DropdownMenuSeparator />
         <Listening sessionId={sessionId} />
@@ -50,14 +53,14 @@ function Copy() {
   );
 }
 
-function Folder({ sessionId }: { sessionId: string }) {
+function Folder({ sessionId, setOpen }: { sessionId: string; setOpen?: (open: boolean) => void }) {
   return (
     <DropdownMenuSub>
       <DropdownMenuSubTrigger className="cursor-pointer">
         <FolderIcon />
         <span>Move to</span>
       </DropdownMenuSubTrigger>
-      <SearchableFolderSubmenuContent sessionId={sessionId} />
+      <SearchableFolderSubmenuContent sessionId={sessionId} setOpen={setOpen} />
     </DropdownMenuSub>
   );
 }
diff --git a/apps/desktop/src/components/main/body/sessions/outer-header/shared/folder.tsx b/apps/desktop/src/components/main/body/sessions/outer-header/shared/folder.tsx
@@ -42,7 +42,9 @@ export function SearchableFolderDropdown({ sessionId, trigger }: { sessionId: st
   );
 }
 
-export function SearchableFolderSubmenuContent({ sessionId }: { sessionId: string }) {
+export function SearchableFolderSubmenuContent(
+  { sessionId, setOpen }: { sessionId: string; setOpen?: (open: boolean) => void },
+) {
   const folders = persisted.UI.useResultTable(persisted.QUERIES.visibleFolders, persisted.STORE_ID);
 
   const handleSelectFolder = persisted.UI.useSetPartialRowCallback(
@@ -56,7 +58,7 @@ export function SearchableFolderSubmenuContent({ sessionId }: { sessionId: strin
   return (
     <DropdownMenuSubContent className="w-[200px] p-0">
       {Object.keys(folders).length
-        ? <SearchableFolderContent folders={folders} onSelectFolder={handleSelectFolder} />
+        ? <SearchableFolderContent folders={folders} onSelectFolder={handleSelectFolder} setOpen={setOpen} />
         : <div className="py-6 text-center text-sm text-muted-foreground">No folders available</div>}
     </DropdownMenuSubContent>
   );

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,9 @@`
`1`	`1`	`import { useMeetingMetadata } from "./shared";`
`2`	`2`
`3`	`3`	`export function MeetingDescription({ sessionId }: { sessionId: string }) {`
`4`		`- const meta = useMeetingMetadata(sessionId)!;`
	`4`	`+ const meta = useMeetingMetadata(sessionId);`
`5`	`5`
`6`		`- if (!meta.description) {`
	`6`	`+ if (!meta?.description) {`
`7`	`7`	`return null;`
`8`	`8`	`}`
`9`	`9`
Original file line number	Diff line number	Diff line change
`@@ -3,9 +3,9 @@ import { MapPinIcon } from "lucide-react";`
`3`	`3`	`import { useMeetingMetadata } from "./shared";`
`4`	`4`
`5`	`5`	`export function MeetingLocation({ sessionId }: { sessionId: string }) {`
`6`		`- const meta = useMeetingMetadata(sessionId)!;`
	`6`	`+ const meta = useMeetingMetadata(sessionId);`
`7`	`7`
`8`		`- if (!meta.location) {`
	`8`	`+ if (!meta?.location) {`
`9`	`9`	`return null;`
`10`	`10`	`}`
`11`	`11`