Fix the --watch flag for AssemblyScript
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
triblondon
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476
Problem: When implementing the
--watchfunctionality we neglected to notice that the source code directory for AssemblyScript wasn'tsrc(as it is with JavaScript and Rust) and so when it came to using the--watchflag we had hardcoded"src"to be watched.Solution: We inspect the
--languageflag, falling back to the fastly.toml manifest to identify the language and use that information to identify the correct source code directory to watch.Screenshots: The following screenshot shows that the compiled binary now correctly runs the
compute serve --watchcommand and will (when an update is made to a file) trigger the hot reload functionality.