Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add TypeScript about @types/mime #67

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

climba03003
Copy link
Member

Ref #60

Checklist

@climba03003 climba03003 requested a review from Fdawgs April 2, 2024 15:41
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6fd44c8 into master Apr 2, 2024
2 checks passed
@gurgunday gurgunday deleted the docs-typescript branch April 2, 2024 19:13
Fdawgs added a commit that referenced this pull request Apr 3, 2024
Didn't get to #67 fast enough to review it last night

Signed-off-by: Frazer Smith <frazer.dev@outlook.com>
@Fdawgs Fdawgs mentioned this pull request Apr 3, 2024
2 tasks
gurgunday pushed a commit that referenced this pull request Apr 3, 2024
* docs(readme): tidy typescript section

Didn't get to #67 fast enough to review it last night

Signed-off-by: Frazer Smith <frazer.dev@outlook.com>

* Update README.md

Signed-off-by: Frazer Smith <frazer.dev@outlook.com>

* Update README.md

Signed-off-by: Frazer Smith <frazer.dev@outlook.com>

---------

Signed-off-by: Frazer Smith <frazer.dev@outlook.com>
@Fdawgs
Copy link
Member

Fdawgs commented Nov 11, 2024

@climba03003 Would you say this closes #60?

@climba03003
Copy link
Member Author

climba03003 commented Nov 11, 2024

No, they are different things.
The issue you mention is about what action we should done for the ESM package ecosystem changes.

It can be issued by change to use import or stay in old version, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants