Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use standard #13

Merged
merged 1 commit into from
May 21, 2021
Merged

style: use standard #13

merged 1 commit into from
May 21, 2021

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented May 21, 2021 •
edited
Loading

Resolve #5

Notable changes:

  • top-level return replaced by process.exit(0) - install.js#L69, uninstall.js#L30
  • if-else inverted - index.js#L310

Checklist

@zekth
Copy link
Member

zekth commented May 21, 2021

Why is the process.exit(0) needed? Won't it create side effect?

mcollina
mcollina approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003
Copy link
Member Author

climba03003 commented May 21, 2021 •
edited
Loading

Why is the process.exit(0) needed? Won't it create side effect?

top-level return cannot be properly parse by standardjs.
standard/standard#510

zekth
zekth approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsumners
jsumners approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jsumners jsumners merged commit 0dc9d73 into main May 21, 2021
@jsumners jsumners deleted the lint-standard branch May 21, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@zekth zekth zekth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply standard linting
4 participants
@climba03003 @zekth @mcollina @jsumners