Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backing web app #103

Closed
2 tasks done
simoneb opened this issue Nov 20, 2021 · 6 comments · Fixed by #106 or #107
Closed
2 tasks done

Remove backing web app #103

simoneb opened this issue Nov 20, 2021 · 6 comments · Fixed by #106 or #107
Assignees

Comments

@simoneb
Copy link
Collaborator

simoneb commented Nov 20, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

GitHub announced that dependabot will now respect the GITHUB_TOKEN permissions configured in workflows.

https://github.blog/changelog/2021-10-06-github-actions-workflows-triggered-by-dependabot-prs-will-respect-permissions-key-in-workflows/

Because of this, there's a good chance that this action won't need the backing web app it's currently using and can be rewritten as a plain, self-contained action.

Motivation

No response

Example

No response

@mcollina
Copy link
Member

I don't think it's simple or feasible migrating to this as it requires a human to change the action format.

I think we should fork this repo and create a fresh action with new instructions.

@simoneb
Copy link
Collaborator Author

simoneb commented Nov 20, 2021

That's an option as well. Just so we're on the same line, to the best of my understanding this would require a change in the workflow yml file where this action is used, to include a permissions entry which gives the github token pull request write permissions. This change could be easily scriptable in most scenarios.

@mcollina
Copy link
Member

How is it scriptable? Could the current action make the change on its own to all the repos it is installed on? Would it be the right thing to do?

@simoneb
Copy link
Collaborator Author

simoneb commented Nov 20, 2021

The action cannot do this change itself, it's the workflow's yml file that needs to change to include additional configuration. It can be scripted in the sense that a script could go around and update all the workflows where the action is being used, at least within the fastify organization.

@mcollina
Copy link
Member

+1 on the script!

Could you make sure (without any modifications to the action file) that this action is not self-updating to the next major?

I would like to prevent a scenario where we break all our users without giving them time to upgrade.

@Eomm
Copy link
Member

Eomm commented Dec 13, 2021

+1 on the script!

Could you make sure (without any modifications to the action file) that this action is not self-updating to the next major?

I would like to prevent a scenario where we break all our users without giving them time to upgrade.

Regarding this aspect, I wrote an automation-migration script:
https://github.com/fastify/github-action-merge-dependabot/blob/migration-script/scripts/migration/migrate.js

It needs to be run locally and it will update all the repositories listed in this file:

https://github.com/fastify/github-action-merge-dependabot/blob/migration-script/scripts/migration/repositories.txt

@Eomm Eomm closed this as completed in #107 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants