-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 4.24.1 breaks build #5094
Comments
asyncDispose was introduced with #5082 by @arthurfiorette If I remember correctly Symbol.asyncDispose was added to the node typings last week or so, by uncommenting the already existing comments. Dont know if it is released already. Maybe by using latest nodejs v20 typings it will not throw typescript errors. Dont know if asyncDispose is available for node v18, or if the typings were backported to v18. We could try to fix the typings by adding a ts-ignore above asyncDispose. But I wonder... What if e.g. node 14 does not have asyncDispose. Does this mean that fastify instances have a potential |
Oh wait. Merged 3 hours ago It needs typescript 5.2? |
It probably only breaks with |
@rebelchris are you using nodejs 18, right? This error only appears if |
@arthurfiorette my nodes/rypes are set to 18.16.17 |
And what typescript version? |
Typescript 5.2.2 |
released v4.24.2 |
Thanks everyone for the swift actions. |
Prerequisites
Fastify version
4.24.1
Plugin version
No response
Node.js version
18.16
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
14.0
Description
If I bump from 4.23.2 to 4.24.1 I get following build error.
Not 100% sure if it's related, but seems to be the stuff introduced here.
Error I get:
Wondering if anyone can shed some light on it, or advise.
Steps to Reproduce
I don't have bare minimal reproduction, but you can see the fail from bump here.
Expected Behavior
No response
The text was updated successfully, but these errors were encountered: