Fix: Test script cannot detect test under test directory with deep level#708
Merged
mcollina merged 6 commits intofastify:masterfrom Feb 23, 2024
Merged
Fix: Test script cannot detect test under test directory with deep level#708mcollina merged 6 commits intofastify:masterfrom
mcollina merged 6 commits intofastify:masterfrom
Conversation
mcollina
reviewed
Feb 23, 2024
Co-authored-by: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: adamward459 <adamward459@gmail.com>
Contributor
Author
|
Can you retry the window job @mcollina ? i don't know what went wrong with it |
|
This change seems to break node versions <21 for me when running |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
System information
The demo can be found here
Mac os: 14.3.1 (23D60)
Node: v21.6.2
Npm: 10.2.4
Reproduce
List all tests under the test directory
➜ demo-fastify git:(main) find ./test -name "*.test.ts" ./test/plugins/support.test.ts ./test/routes/example.test.ts ./test/routes/root.test.ts ./test/routes/routes/example.test.ts ./test/routes/routes/root.test.ts ./test/routes/routes/routes/example.test.ts ./test/routes/routes/routes/root.test.tsRun
testcommand, the test command can only figure out files at first level.After I change the pattern to include double quote mark, here is the result: