Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json file already exists in target directory #701

Open
2 tasks done
jebarpg opened this issue Jan 27, 2024 · 2 comments
Open
2 tasks done

package.json file already exists in target directory #701

jebarpg opened this issue Jan 27, 2024 · 2 comments
Labels
feature request New feature to be added

Comments

@jebarpg
Copy link

jebarpg commented Jan 27, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.25.2

Plugin version

No response

Node.js version

21.6.1

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

Clear Linux OS installed version 40410

Description

fastify generate should update the package.json file and not error out that the package.json file already exists. Basically there should be a check for the file and if it exists then read it into a json object then work with adding new key,values that are needed for the generated typescript or javascript project boilerplate. This should be done for the tsconfig.json as well. The npm pkg can be used for this as well npm pkg set
See: https://docs.npmjs.com/cli/v7/commands/npm-pkg

Steps to Reproduce

I run
bun init
to generate a package.json file and tsconfig.json file
then I run
fastify generate --lang=ts .
to generate a typescript project in the current directory and get the error:
a package.json file already exists in target directory

Expected Behavior

No response

@Eomm
Copy link
Member

Eomm commented Jan 28, 2024

fastify generate should update the package.json file and not error out that the package.json file already exists.

Yeah, it is not supported now.

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@Eomm Eomm added the feature request New feature to be added label Jan 28, 2024
@10xLaCroixDrinker
Copy link
Contributor

This does work if you use the --integrate flag since #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature to be added
Projects
None yet
Development

No branches or pull requests

3 participants